Review Request: Fix bug 246898: Take opacity into consideration while drawing venn diagrams

[Gopalakrishna Bhat]

> On June 20, 2012, 7:16 a.m., Thorsten Zachmann wrote:
> > libs/flake/KoGradientBackground.cpp, lines 142-144
> > <http://git.reviewboard.kde.org/r/105301/diff/1/?file=69823#file69823line142>
> >
> >     Did you check that this does not have any effect on the gradient that is saved?

I found that setting alpha for the linear gradient is not the correct way, so added code to set opacity to gradient stop points


> On June 20, 2012, 7:16 a.m., Thorsten Zachmann wrote:
> > libs/odf/KoOdfGraphicStyles.cpp, line 111
> > <http://git.reviewboard.kde.org/r/105301/diff/1/?file=69825#file69825line111>
> >
> >     The code cannot be moved to here as other cases also write out the draw:opacity and therefore it could end up writing out the attribute twice. So best copy the code with the if to the gradient case.

In the updated patch there is no code change here


- Gopalakrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105301/#review14903
-----------------------------------------------------------


On June 19, 2012, 5 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105301/
> -----------------------------------------------------------
> 
> (Updated June 19, 2012, 5 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Take draw:opacity into consideration while loading and saving style:graphic-properties
> 
> 
> This addresses bug 246898.
>     http://bugs.kde.org/show_bug.cgi?id=246898
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoGradientBackground.cpp 3db1537 
>   libs/flake/KoOdfGradientBackground.cpp 4538702 
>   libs/odf/KoOdfGraphicStyles.cpp 835e9f1 
> 
> Diff: http://git.reviewboard.kde.org/r/105301/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120623/208cdfe5/attachment.htm>