Review Request: Fix bug 246898: Take opacity into consideration while drawing venn diagrams

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105301/#review14903
-----------------------------------------------------------



libs/flake/KoGradientBackground.cpp
<http://git.reviewboard.kde.org/r/105301/#comment11697>

    Did you check that this does not have any effect on the gradient that is saved?



libs/flake/KoGradientBackground.cpp
<http://git.reviewboard.kde.org/r/105301/#comment11698>

    This should be moved down int the if and only loaded if loading of the gradient was successful.



libs/flake/KoOdfGradientBackground.cpp
<http://git.reviewboard.kde.org/r/105301/#comment11695>

    The opacity should only be saved if it is smaller 1.



libs/flake/KoOdfGradientBackground.cpp
<http://git.reviewboard.kde.org/r/105301/#comment11699>

    This should be moved down into the if (fillStyle == "gradient")



libs/odf/KoOdfGraphicStyles.cpp
<http://git.reviewboard.kde.org/r/105301/#comment11696>

    The code cannot be moved to here as other cases also write out the draw:opacity and therefore it could end up writing out the attribute twice. So best copy the code with the if to the gradient case.


- Thorsten Zachmann


On June 19, 2012, 5 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105301/
> -----------------------------------------------------------
> 
> (Updated June 19, 2012, 5 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Take draw:opacity into consideration while loading and saving style:graphic-properties
> 
> 
> This addresses bug 246898.
>     http://bugs.kde.org/show_bug.cgi?id=246898
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoGradientBackground.cpp 3db1537 
>   libs/flake/KoOdfGradientBackground.cpp 4538702 
>   libs/odf/KoOdfGraphicStyles.cpp 835e9f1 
> 
> Diff: http://git.reviewboard.kde.org/r/105301/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120620/15aaa5cd/attachment.htm>