Review Request: Fix some icon names to reference existing icons (2.5 branch)

Tue Jun 19 19:53:49 BST 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105284/
-----------------------------------------------------------

(Updated June 19, 2012, 6:53 p.m.)

Review request for Calligra.

Changes
-------

Update patch based on discussion.

Description (updated)
-------

Fixes all those icon names referencing to non-existing icons for which there is a proper icon in Oxygen 4.3.5 or coming with Calligra itself (IMHO :))

Also removes all arrow icons from plugins/pathshapes/pics, because they are either not used or can be replaced by draw-arrow-* icons from Oxygen icons.

Okay to commit both to master and 2.5?

Dealt entries from the report of the koIcon script, commented how I propose to solve it:

arrow-down-calligra
    plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:298
arrow-up-calligra
    plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:265
arrow-left-calligra
    plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:232

Use the draw-arrow-* icons from Oxygen.

star
    plugins/pathshapes/star/StarShapeFactory.cpp:40

14_layer_novisible
    libs/kopageapp/KoPADocumentModel.cpp:314
14_layer_visible
    libs/kopageapp/KoPADocumentModel.cpp:314

Oxygen from 4.3.5 has layer-visible-on and layer-visible-off icons, so use them.

fontsizeup
    sheets/ui/CellToolBase.cpp:415
fontsizedown
    sheets/ui/CellToolBase.cpp:421

There is also no icon in Kate/KWrite for these setting all text to lower/upper-case, so for now just use no icon here as well.

text
    plugins/artistictextshape/ArtisticTextShapeFactory.cpp:33

Solved by reusing x-shape-text

open
    plugins/pictureshape/PictureTool.cpp:110
    plugins/staging/templateshape/TemplateTool.cpp:90
    plugins/vectorshape/VectorTool.cpp:75

Solved by changing to document-open

Diffs (updated)
-----

  krita/plugins/colorspaces/ctlcs/tests/CMakeLists.txt 200e694 
  krita/plugins/colorspaces/ctlcs/tests/KoCtlColorSpaceInfoTest.cpp 96ac446 
  krita/plugins/colorspaces/ctlcs/tests/KoRgb32fTest.h PRE-CREATION 
  krita/plugins/colorspaces/ctlcs/tests/KoRgb32fTest.cpp PRE-CREATION 
  krita/ui/kra/kis_kra_loader.cpp f6471ff 
  libs/kopageapp/KoPADocumentModel.cpp 69feb88 
  libs/kotext/KoTextBlockBorderData.h b1e0332 
  libs/kotext/KoTextBlockBorderData.cpp 26f788b 
  libs/kotext/styles/KoParagraphStyle.cpp 844903a 
  libs/main/calligraversion.h e58bf48 
  libs/textlayout/KoTextLayoutArea.cpp 7f90980 
  libs/textlayout/KoTextLayoutArea_paint.cpp 546cdeb 
  libs/textlayout/KoTextLayoutObstruction.cpp 855a72a 
  libs/textlayout/KoTextShapeData.cpp e97b372 
  plan/kptprintingcontrolprivate.h c7ec0eb 
  plan/kptview.h dd0fe80 
  plan/kptview.cpp 03195f0 
  plan/libs/ui/kptaccountseditor.h 1440817 
  plan/libs/ui/kptaccountseditor.cpp a609de5 
  plan/libs/ui/kptaccountsview.cpp 9aa4d7e 
  plan/libs/ui/kptaccountsviewconfigdialog.h 117c4c2 
  plan/libs/ui/kptaccountsviewconfigdialog.cpp be15755 
  plan/libs/ui/kptdependencyeditor.h 2c214b7 
  plan/libs/ui/kptdependencyeditor.cpp 6ca6550 
  plan/libs/ui/kptdocumentseditor.cpp 73632bf 
  plan/libs/ui/kptganttview.h 2ddb13e 
  plan/libs/ui/kptganttview.cpp 939a415 
  plan/libs/ui/kptitemviewsettup.h 6d16bff 
  plan/libs/ui/kptitemviewsettup.cpp df7c3f7 
  plan/libs/ui/kptpertresult.cpp 00e8e93 
  plan/libs/ui/kptrelationeditor.cpp 2ce5bbd 
  plan/libs/ui/kptresourceallocationeditor.cpp e78548d 
  plan/libs/ui/kptresourceappointmentsview.h 4cf6565 
  plan/libs/ui/kptresourceappointmentsview.cpp b7f80e6 
  plan/libs/ui/kptresourceeditor.cpp 968104d 
  plan/libs/ui/kptscheduleeditor.cpp aaf6464 
  plan/libs/ui/kpttaskeditor.cpp 12527c8 
  plan/libs/ui/kpttaskstatusview.h fa86d55 
  plan/libs/ui/kpttaskstatusview.cpp 2ff3ef6 
  plan/libs/ui/kptviewbase.h de087d2 
  plan/libs/ui/kptviewbase.cpp 753f436 
  plan/libs/ui/reports/reportview.cpp f1aa649 
  plan/workpackage/taskworkpackageview.cpp db6ddee 
  plugins/artistictextshape/ArtisticTextShapeFactory.cpp 2438b20 
  plugins/chartshape/ChartProxyModel.cpp 600d4fe 
  plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp d820c43 
  plugins/pathshapes/pics/hi22-action-arrow-down.png c7e4dec 
  plugins/pathshapes/pics/hi22-action-arrow-left-down.png d2443c8 
  plugins/pathshapes/pics/hi22-action-arrow-left-up.png 20afbd4 
  plugins/pathshapes/pics/hi22-action-arrow-left.png 2aff72f 
  plugins/pathshapes/pics/hi22-action-arrow-right-down.png f165711 
  plugins/pathshapes/pics/hi22-action-arrow-right-up.png f095b9a 
  plugins/pathshapes/pics/hi22-action-arrow-up.png a1f66da 
  plugins/pathshapes/pics/ox22-action-arrow-right-calligra.png dbb9e5a 
  plugins/pathshapes/star/StarShapeFactory.cpp e6a9c6d 
  plugins/pictureshape/PictureTool.cpp bf15751 
  plugins/staging/googledocs/CMakeLists.txt b0f67a5 
  plugins/staging/googledocs/googledocumentservice.cpp bcc6ecc 
  plugins/staging/googledocs/onlinedocument.h d4141f3 
  plugins/staging/googledocs/onlinedocument.cpp 3f55a62 
  plugins/staging/templateshape/TemplateTool.cpp 6373aa2 
  plugins/vectorshape/VectorTool.cpp 79742fd 
  sheets/ui/CellToolBase.cpp 89b79f9 

Diff: http://git.reviewboard.kde.org/r/105284/diff/

Testing
-------

Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120619/31494ed2/attachment.htm>