<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105284/">http://git.reviewboard.kde.org/r/105284/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 19, 2012, 6:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update patch based on discussion.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes all those icon names referencing to non-existing icons for which there is a proper icon in Oxygen 4.3.5 or coming with Calligra itself (IMHO :))
Also removes all arrow icons from plugins/pathshapes/pics, because they are either not used or can be replaced by draw-arrow-* icons from Oxygen icons.
Okay to commit both to master and 2.5?
Dealt entries from the report of the koIcon script, commented how I propose to solve it:
arrow-down-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:298
arrow-up-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:265
arrow-left-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:232
Use the draw-arrow-* icons from Oxygen.
star
plugins/pathshapes/star/StarShapeFactory.cpp:40
14_layer_novisible
libs/kopageapp/KoPADocumentModel.cpp:314
14_layer_visible
libs/kopageapp/KoPADocumentModel.cpp:314
Oxygen from 4.3.5 has layer-visible-on and layer-visible-off icons, so use them.
fontsizeup
sheets/ui/CellToolBase.cpp:415
fontsizedown
sheets/ui/CellToolBase.cpp:421
There is also no icon in Kate/KWrite for these setting all text to lower/upper-case, so for now just use no icon here as well.
text
plugins/artistictextshape/ArtisticTextShapeFactory.cpp:33
Solved by reusing x-shape-text
open
plugins/pictureshape/PictureTool.cpp:110
plugins/staging/templateshape/TemplateTool.cpp:90
plugins/vectorshape/VectorTool.cpp:75
Solved by changing to document-open</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/colorspaces/ctlcs/tests/CMakeLists.txt <span style="color: grey">(200e694)</span></li>
<li>krita/plugins/colorspaces/ctlcs/tests/KoCtlColorSpaceInfoTest.cpp <span style="color: grey">(96ac446)</span></li>
<li>krita/plugins/colorspaces/ctlcs/tests/KoRgb32fTest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/colorspaces/ctlcs/tests/KoRgb32fTest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kra/kis_kra_loader.cpp <span style="color: grey">(f6471ff)</span></li>
<li>libs/kopageapp/KoPADocumentModel.cpp <span style="color: grey">(69feb88)</span></li>
<li>libs/kotext/KoTextBlockBorderData.h <span style="color: grey">(b1e0332)</span></li>
<li>libs/kotext/KoTextBlockBorderData.cpp <span style="color: grey">(26f788b)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.cpp <span style="color: grey">(844903a)</span></li>
<li>libs/main/calligraversion.h <span style="color: grey">(e58bf48)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(7f90980)</span></li>
<li>libs/textlayout/KoTextLayoutArea_paint.cpp <span style="color: grey">(546cdeb)</span></li>
<li>libs/textlayout/KoTextLayoutObstruction.cpp <span style="color: grey">(855a72a)</span></li>
<li>libs/textlayout/KoTextShapeData.cpp <span style="color: grey">(e97b372)</span></li>
<li>plan/kptprintingcontrolprivate.h <span style="color: grey">(c7ec0eb)</span></li>
<li>plan/kptview.h <span style="color: grey">(dd0fe80)</span></li>
<li>plan/kptview.cpp <span style="color: grey">(03195f0)</span></li>
<li>plan/libs/ui/kptaccountseditor.h <span style="color: grey">(1440817)</span></li>
<li>plan/libs/ui/kptaccountseditor.cpp <span style="color: grey">(a609de5)</span></li>
<li>plan/libs/ui/kptaccountsview.cpp <span style="color: grey">(9aa4d7e)</span></li>
<li>plan/libs/ui/kptaccountsviewconfigdialog.h <span style="color: grey">(117c4c2)</span></li>
<li>plan/libs/ui/kptaccountsviewconfigdialog.cpp <span style="color: grey">(be15755)</span></li>
<li>plan/libs/ui/kptdependencyeditor.h <span style="color: grey">(2c214b7)</span></li>
<li>plan/libs/ui/kptdependencyeditor.cpp <span style="color: grey">(6ca6550)</span></li>
<li>plan/libs/ui/kptdocumentseditor.cpp <span style="color: grey">(73632bf)</span></li>
<li>plan/libs/ui/kptganttview.h <span style="color: grey">(2ddb13e)</span></li>
<li>plan/libs/ui/kptganttview.cpp <span style="color: grey">(939a415)</span></li>
<li>plan/libs/ui/kptitemviewsettup.h <span style="color: grey">(6d16bff)</span></li>
<li>plan/libs/ui/kptitemviewsettup.cpp <span style="color: grey">(df7c3f7)</span></li>
<li>plan/libs/ui/kptpertresult.cpp <span style="color: grey">(00e8e93)</span></li>
<li>plan/libs/ui/kptrelationeditor.cpp <span style="color: grey">(2ce5bbd)</span></li>
<li>plan/libs/ui/kptresourceallocationeditor.cpp <span style="color: grey">(e78548d)</span></li>
<li>plan/libs/ui/kptresourceappointmentsview.h <span style="color: grey">(4cf6565)</span></li>
<li>plan/libs/ui/kptresourceappointmentsview.cpp <span style="color: grey">(b7f80e6)</span></li>
<li>plan/libs/ui/kptresourceeditor.cpp <span style="color: grey">(968104d)</span></li>
<li>plan/libs/ui/kptscheduleeditor.cpp <span style="color: grey">(aaf6464)</span></li>
<li>plan/libs/ui/kpttaskeditor.cpp <span style="color: grey">(12527c8)</span></li>
<li>plan/libs/ui/kpttaskstatusview.h <span style="color: grey">(fa86d55)</span></li>
<li>plan/libs/ui/kpttaskstatusview.cpp <span style="color: grey">(2ff3ef6)</span></li>
<li>plan/libs/ui/kptviewbase.h <span style="color: grey">(de087d2)</span></li>
<li>plan/libs/ui/kptviewbase.cpp <span style="color: grey">(753f436)</span></li>
<li>plan/libs/ui/reports/reportview.cpp <span style="color: grey">(f1aa649)</span></li>
<li>plan/workpackage/taskworkpackageview.cpp <span style="color: grey">(db6ddee)</span></li>
<li>plugins/artistictextshape/ArtisticTextShapeFactory.cpp <span style="color: grey">(2438b20)</span></li>
<li>plugins/chartshape/ChartProxyModel.cpp <span style="color: grey">(600d4fe)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp <span style="color: grey">(d820c43)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-down.png <span style="color: grey">(c7e4dec)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-left-down.png <span style="color: grey">(d2443c8)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-left-up.png <span style="color: grey">(20afbd4)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-left.png <span style="color: grey">(2aff72f)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-right-down.png <span style="color: grey">(f165711)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-right-up.png <span style="color: grey">(f095b9a)</span></li>
<li>plugins/pathshapes/pics/hi22-action-arrow-up.png <span style="color: grey">(a1f66da)</span></li>
<li>plugins/pathshapes/pics/ox22-action-arrow-right-calligra.png <span style="color: grey">(dbb9e5a)</span></li>
<li>plugins/pathshapes/star/StarShapeFactory.cpp <span style="color: grey">(e6a9c6d)</span></li>
<li>plugins/pictureshape/PictureTool.cpp <span style="color: grey">(bf15751)</span></li>
<li>plugins/staging/googledocs/CMakeLists.txt <span style="color: grey">(b0f67a5)</span></li>
<li>plugins/staging/googledocs/googledocumentservice.cpp <span style="color: grey">(bcc6ecc)</span></li>
<li>plugins/staging/googledocs/onlinedocument.h <span style="color: grey">(d4141f3)</span></li>
<li>plugins/staging/googledocs/onlinedocument.cpp <span style="color: grey">(3f55a62)</span></li>
<li>plugins/staging/templateshape/TemplateTool.cpp <span style="color: grey">(6373aa2)</span></li>
<li>plugins/vectorshape/VectorTool.cpp <span style="color: grey">(79742fd)</span></li>
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(89b79f9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105284/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>