List of missing icons around 2.5 branching

Sun Jun 17 04:40:10 BST 2012

Hi,

so unless I failed with my first Python script ever (or elsewhere) I can give 
you an automatically created list with the currenty missing icons.

I used a primitive approach to create the list (will by improved by the time, 
but its at least a start):
with xgettext all icon names are extracted from the sources (with my koIcon 
patch, so line numbers might be not exact), the icon names in the .desktop 
files with grep. Then compared these to the list of all icon names in a 
tarball with the oxygen icons from the KDE 4.3.5 release, as well with the 
name of all icons in the directories of Calligra (not yet checked if installed 
at all, just by "find -name "*.png" and also handling iconset format names if 
used). Any other places with icon references that I may have missed?

See 
http://quickgit.kde.org/index.php?p=clones%2Fcalligra%2Fkossebau%2Fcalligra.git&a=shortlog&h=refs/heads/introduceKoIcon
for the current WIP state. Review request coming soon...

Below the list which is currently created by my script. But I added also some 
comments. Its not sorted, but maintainers surely will see where their code is 
affected. Some missing icons are known, others may not.

edit-duplicate
    krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp:416

But there is a krita/plugins/paintops/defaultpaintops/krita-duplicate.png

vector-shape
    plugins/vectorshape/VectorShapeFactory.cpp:42
music-clef-trebble
    plugins/musicshape/actions/SetClefAction.cpp:41
music-clef
    plugins/musicshape/actions/SetClefAction.cpp:44
zoom-draw
    karbon/ui/KarbonView.cpp:1210
    libs/widgets/KoZoomAction.cpp:286
office-chart-stock
    plugins/chartshape/ChartConfigWidget.cpp:1544
splitter
    kexi/formeditor/factories/containerfactory.cpp:568
vector
    plugins/formulashape/KoFormulaTool.cpp:426
kde_events
    stage/templates/odf/kde_events.desktop

Okay, template, false alarm.

duplicate
    braindump/src/View.cpp:193
arrow-left-calligra
    plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:232
music-clef-bass
    plugins/musicshape/actions/SetClefAction.cpp:42
arrow-down-calligra
    plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:298
root
    plugins/formulashape/KoFormulaTool.cpp:413
edit-table-cell-split
    plugins/textshape/TextTool.cpp:463
bevelled
    plugins/formulashape/KoFormulaTool.cpp:419
office-chart-polar-filled
    plugins/chartshape/ChartConfigWidget.cpp:301
    plugins/chartshape/ChartConfigWidget.cpp:350
    plugins/chartshape/ChartConfigWidget.cpp:407
    plugins/chartshape/ChartConfigWidget.cpp:1541
add-vertical-edges
    plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.cpp:32
hflow
    kexi/formeditor/factories/containerfactory.cpp:579
window
    plan/libs/ui/reports/reportview.cpp:660
this-action
    plugins/chartshape/ChartTool.cpp:98
that-action
    plugins/chartshape/ChartTool.cpp:103

Hm, so xgettext also extracts from commented code?

musicflake
    plugins/musicshape/MusicShapeFactory.cpp:53
musicshape
    plugins/musicshape/MusicToolFactory.cpp:33
calligramobile
    active/calligraactive.desktop
    active/calligraactive.desktop
snap-boundingbox
    libs/flake/SnapGuideConfigWidget.cpp:34
tool-changetracking
    plugins/textshape/ReviewToolFactory.cpp:36
office-chart-gantt
    plugins/chartshape/ChartConfigWidget.cpp:1553
tool-references
    plugins/textshape/ReferencesToolFactory.cpp:34
erase-previous-guides
    plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.cpp:30
krita_paintop_icon
    krita/ui/widgets/kis_paintop_presets_popup.cpp:92
open
    plugins/pictureshape/PictureTool.cpp:110
    plugins/staging/templateshape/TemplateTool.cpp:90
    plugins/vectorshape/VectorTool.cpp:75
rsubup
    plugins/formulashape/KoFormulaTool.cpp:433
relations
    kexi/plugins/relations/kexirelationhandler.desktop
csv_importexport
    kexi/plugins/importexport/csv/kexicsv_importexporthandler.desktop
    kexi/plugins/importexport/csv/kexicsv_importexporthandler.desktop
office-chart-bubble
    plugins/chartshape/ChartConfigWidget.cpp:1547
clearComment
    sheets/ui/CellToolBase_p.cpp:1300
vflow
    kexi/formeditor/factories/containerfactory.cpp:588
edit-table-cell-merge
    plugins/textshape/TextTool.cpp:459
music-clef-alto
    plugins/musicshape/actions/SetClefAction.cpp:43
progress-bar
    kexi/plugins/forms/kexidbfactory.cpp:340
pictureshape
    plugins/pictureshape/PictureToolFactory.cpp:33
document-page-setup
    kexi/main/KexiMainWindow.cpp:628
    kexi/widget/navigator/KexiProjectListView.cpp:223
    kexi/widget/navigator/KexiProjectNavigator.cpp:194
arrow_center
    krita/plugins/extensions/imagesize/dlg_canvassize.cc:282
curious_penguin
    stage/templates/odf/curious_penguin.desktop
zoom-select
    karbon/ui/KarbonView.cpp:1206
    libs/widgets/KoZoomAction.cpp:278
fontsizeup
    sheets/ui/CellToolBase.cpp:415
enhancedpath
    plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:42
filequickprint
    tools/quickprint/karbon_konqi.desktop
    tools/quickprint/kspread_konqi.desktop
    tools/quickprint/kformula_konqi.desktop
    tools/quickprint/kpresenter_konqi.desktop
    tools/quickprint/kchart_konqi.desktop
    tools/quickprint/words_konqi.desktop
    tools/quickprint/flow_konqi.desktop
    tools/quickprint/krita_konqi.desktop
layer-new
    libs/kopageapp/KoPADocumentStructureDocker.cpp:117
gsubup
    plugins/formulashape/KoFormulaTool.cpp:439
office-chart-surface
    plugins/chartshape/ChartConfigWidget.cpp:1550
inspector
    sheets/ui/CellToolBase.cpp:812
file_import
    kexi/plugins/importexport/csv/kexicsvimportdialog.cpp:81
migration
    kexi/plugins/migration/keximigrationhandler.desktop
    kexi/plugins/migration/keximigrationhandler.desktop
fontsizedown
    sheets/ui/CellToolBase.cpp:421
okular
    tools/okularodpgenerator/okularodp.desktop
    tools/okularodpgenerator/okularapplication_odp.desktop
enclosed
    plugins/formulashape/KoFormulaTool.cpp:411
arrow-up-calligra
    plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:265

There is ./plugins/pathshapes/pics/hi22-action-arrow-up.png But in that 
directory only one of the files has a "-calligra" postfix, why?

commentTool
    plugins/commentshape/CommentToolFactory.cpp:32
effectimages
    karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp:33
vectorshape
    plugins/vectorshape/VectorToolFactory.cpp:34
edit-merge
    krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp:417
14_layer_visible
    libs/kopageapp/KoPADocumentModel.cpp:314
14_layer_novisible
    libs/kopageapp/KoPADocumentModel.cpp:314

These both were removed by "karbon: icon cleanup" from 06/06/2012
But there are still ./krita/pics/novisible.png and ./krita/pics/visible.png, 
though in a different size (22, not 16 like the karbon one).

tool-pagelayout
    words/part/pagetool/KWPageToolFactory.cpp:33
star
    plugins/pathshapes/star/StarShapeFactory.cpp:40

"star-shape" would be the fix here obviously.

add-horizontal-edges
    plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.cpp:31