Review Request: improvements in chartshape

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105230/#review14714
-----------------------------------------------------------

Ship it!


I see a few coding style issues, but eventhough plugins relaly should conform as well I simply don't care enough to complain TM

I only have one issue tht I would like resolved. But given that it has my ship-it too

looks like great work


plugins/chartshape/ChartConfigWidget.cpp
<http://git.reviewboard.kde.org/r/105230/#comment11615>

    Is that really a good uservisible name?


- C. Boemann


On June 12, 2012, 5:25 p.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105230/
> -----------------------------------------------------------
> 
> (Updated June 12, 2012, 5:25 p.m.)
> 
> 
> Review request for Calligra, Inge Wallin and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch :
> i) adds a font editor for axis labels and legend
> ii) adds UI for error bars
> iii) adds UI for stock charts
> iv) fixes load/save styles of all shapes (title,subtitle,axistitles,footer,etc.)
> 
> 
> Diffs
> -----
> 
>   plugins/chartshape/Axis.h b077139 
>   plugins/chartshape/Axis.cpp ffd4a98 
>   plugins/chartshape/CMakeLists.txt b0395ab 
>   plugins/chartshape/ChartConfigWidget.h 6602f19 
>   plugins/chartshape/ChartConfigWidget.cpp 1ddfcdc 
>   plugins/chartshape/ChartConfigWidget.ui 5558bdf 
>   plugins/chartshape/ChartShape.cpp 9217c4c 
>   plugins/chartshape/Legend.cpp 96a0083 
>   plugins/chartshape/PlotArea.cpp 21fa8d6 
>   plugins/chartshape/TODO 64652bd 
>   plugins/chartshape/dialogs/FontEditorDialog.h PRE-CREATION 
>   plugins/chartshape/dialogs/FontEditorDialog.cpp PRE-CREATION 
>   plugins/chartshape/dialogs/FormatErrorBarDialog.h PRE-CREATION 
>   plugins/chartshape/dialogs/FormatErrorBarDialog.cpp PRE-CREATION 
>   plugins/chartshape/dialogs/FormatErrorBarDialog.ui PRE-CREATION 
>   plugins/chartshape/kchart_global.h aa498b9 
>   plugins/chartshape/kdchartpatches/README c2cc190 
>   plugins/chartshape/kdchartpatches/text-overlap.diff PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120613/e5e73a17/attachment.htm>