<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105230/">http://git.reviewboard.kde.org/r/105230/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see a few coding style issues, but eventhough plugins relaly should conform as well I simply don't care enough to complain TM
I only have one issue tht I would like resolved. But given that it has my ship-it too
looks like great work</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105230/diff/1/?file=67392#file67392line410" style="color: black; font-weight: bold; text-decoration: underline;">plugins/chartshape/ChartConfigWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ChartConfigWidget::ChartConfigWidget()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">410</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">dataSetHLCStockChartAction</span> <span class="o">=</span> <span class="n">d</span><span class="o">-></span><span class="n">dataSetStockChartMenu</span><span class="o">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"HighLowClose"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is that really a good uservisible name?</pre>
</div>
<br />
<p>- C.</p>
<br />
<p>On June 12th, 2012, 5:25 p.m., Brijesh Patel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Inge Wallin and C. Boemann.</div>
<div>By Brijesh Patel.</div>
<p style="color: grey;"><i>Updated June 12, 2012, 5:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch :
i) adds a font editor for axis labels and legend
ii) adds UI for error bars
iii) adds UI for stock charts
iv) fixes load/save styles of all shapes (title,subtitle,axistitles,footer,etc.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/chartshape/Axis.h <span style="color: grey">(b077139)</span></li>
<li>plugins/chartshape/Axis.cpp <span style="color: grey">(ffd4a98)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(b0395ab)</span></li>
<li>plugins/chartshape/ChartConfigWidget.h <span style="color: grey">(6602f19)</span></li>
<li>plugins/chartshape/ChartConfigWidget.cpp <span style="color: grey">(1ddfcdc)</span></li>
<li>plugins/chartshape/ChartConfigWidget.ui <span style="color: grey">(5558bdf)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(9217c4c)</span></li>
<li>plugins/chartshape/Legend.cpp <span style="color: grey">(96a0083)</span></li>
<li>plugins/chartshape/PlotArea.cpp <span style="color: grey">(21fa8d6)</span></li>
<li>plugins/chartshape/TODO <span style="color: grey">(64652bd)</span></li>
<li>plugins/chartshape/dialogs/FontEditorDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/dialogs/FontEditorDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/dialogs/FormatErrorBarDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/dialogs/FormatErrorBarDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/dialogs/FormatErrorBarDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/chartshape/kchart_global.h <span style="color: grey">(aa498b9)</span></li>
<li>plugins/chartshape/kdchartpatches/README <span style="color: grey">(c2cc190)</span></li>
<li>plugins/chartshape/kdchartpatches/text-overlap.diff <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105230/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>