Build error

[Dag]

Tirsdag den 12. juni 2012 13:40:17 Boudewijn Rempt skrev:
> On Tuesday 12 June 2012 Jun, Dag wrote:
> > Mandag den 11. juni 2012 11:35:50 Inge Wallin skrev:
> > > There is a build error in the current master that seems to have snuck
> > > past
> > > most people.  My guess is that this is an issue with older kdelibs only.
> > > My
> > > version of KDE is 4.5.2 and of Qt is 4.6.3.
> > 
> > Yes indeed, it is this:
> > ID: 8297e8cbc8267b1dd3e317ab0f03ff053d4cf500
> > 
> >  Added by C. Boemann 3 days ago
> > 
> > Commit several small fixes contributed by Mauro Levra
> > REVIEW:103057
> > 
> > These methods are not present until 4.4 or 4.5. I forgot to check it
> > during
> > the review, sorry.
> > Casper, could you revert this, except for the typo fix in there?
> > I don't have a clean build atm.
> 
> I guess we could just disable building plan and the sheets plugin if Qt is
> too old? I'm still building Krita against Qt 4.6.1 for CentOS 6, so I
> wouldn't want to raise the bar for all of Calligra.
> 
> On the other hand, reverting is pretty drastic as well.
Well, imho the api is only *depreciated* (for new code) and it does not 
disappear until kde5 so I don't really see a good reason to 'fix' it now.
-- 
Mvh.
Dag Andersen