Review Request: Slightly improve the option widget of the document background tool

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105153/
-----------------------------------------------------------

Review request for Calligra and Thorsten Zachmann.


Description
-------

I think the option widget of the background tool would be improved with the attached patch, at least for me it would be more obvious what it does and how to use it. Most important are to state that this (only) about the background of the whole page/slide/document, not normal shapes, and to disable the "Set image..." button if the background of the master slide should be used.

Still not solved: mouse cursor always shows not-allowed cursor.

Commit message is:
    Improve page background tool option widget
    
    * disable "Set image..." button if master page should be used
    * add hint to use Stroke and Fill docker for color
    * improve all texts slightly
    * talk about slide or page depending of page type


Diffs
-----

  libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui ed0c271 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 29fd22e 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp 92ac030 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.h 5888189 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp 332dfb8 

Diff: http://git.reviewboard.kde.org/r/105153/diff/


Testing
-------

Edited backgrounds of masterpage and normal pages both in Stage and Flow.


Screenshots
-----------

New tool options design, here for slides
  http://git.reviewboard.kde.org/r/105153/s/595/


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120605/3335b711/attachment.htm>