Review Request: Show error message to the user on "Export to PDF" failure
Gopalakrishna Bhat
gopalakbhat at gmail.com
Thu Jul 19 18:15:19 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105623/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
Currently while exporting PDF we do not check if we are able to create the file at the location or not. This leads to the "Export to PDF" action to fail silently. This patch adds check for that and the user is notified of failure.
Though I could not test in the exact environment as mentioned in bug 291925, what I did was that I created a folder with no write permissions and tried to export PDF to that folder. In my test environment I could see that export failed silently without this patch.
This addresses bug 291925.
http://bugs.kde.org/show_bug.cgi?id=291925
Diffs
-----
krita/ui/kis_print_job.h 387d64b
krita/ui/kis_print_job.cpp 4f33472
libs/kopageapp/KoPAPrintJob.h 057bb46
libs/kopageapp/KoPAPrintJob.cpp ba069c7
libs/main/KoMainWindow.cpp 98538a8
libs/main/KoPrintJob.h c4fe023
libs/main/KoPrintingDialog.h 6f6583f
libs/main/KoPrintingDialog.cpp 0952906
Diff: http://git.reviewboard.kde.org/r/105623/diff/
Testing
-------
Tested with Words, Stage, Sheets, Plan, Flow and Krita.
Thanks,
Gopalakrishna Bhat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120719/dff913dc/attachment.htm>
More information about the calligra-devel
mailing list