<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105623/">http://git.reviewboard.kde.org/r/105623/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently while exporting PDF we do not check if we are able to create the file at the location or not. This leads to the "Export to PDF" action to fail silently. This patch adds check for that and the user is notified of failure.
Though I could not test in the exact environment as mentioned in bug 291925, what I did was that I created a folder with no write permissions and tried to export PDF to that folder. In my test environment I could see that export failed silently without this patch.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Words, Stage, Sheets, Plan, Flow and Krita.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291925">291925</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/kis_print_job.h <span style="color: grey">(387d64b)</span></li>
<li>krita/ui/kis_print_job.cpp <span style="color: grey">(4f33472)</span></li>
<li>libs/kopageapp/KoPAPrintJob.h <span style="color: grey">(057bb46)</span></li>
<li>libs/kopageapp/KoPAPrintJob.cpp <span style="color: grey">(ba069c7)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(98538a8)</span></li>
<li>libs/main/KoPrintJob.h <span style="color: grey">(c4fe023)</span></li>
<li>libs/main/KoPrintingDialog.h <span style="color: grey">(6f6583f)</span></li>
<li>libs/main/KoPrintingDialog.cpp <span style="color: grey">(0952906)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105623/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>