Review Request: fix parsing of fo:border in KoParagraphStyle
C. Boemann
cbr at boemann.dk
Wed Jul 18 08:45:51 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105604/#review16059
-----------------------------------------------------------
looks good to me too, someone else feel free to say ship it
- C. Boemann
On July 18, 2012, 2:05 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105604/
> -----------------------------------------------------------
>
> (Updated July 18, 2012, 2:05 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Current parsing code for fo:border in KoParagraphStyle was not taking into account all the possible data variation in the value string to parse.
>
> Attached fixes that. As a result "TestOpenDocumentStyle testParagraphStyle" does no longer fail on the attribute fo:border (only on style:shadow, fix coming as separate review request).
>
> Also changes a bad test value (0cm, while only positive integer are allowed here).
>
> Okay to backport to 2.5?
>
>
> Diffs
> -----
>
> libs/kotext/styles/KoParagraphStyle.cpp 820da77
> libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d0aadd4
>
> Diff: http://git.reviewboard.kde.org/r/105604/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120718/f416818d/attachment.htm>
More information about the calligra-devel
mailing list