Review Request: fix parsing of fo:border in KoParagraphStyle
Friedrich W. H. Kossebau
kossebau at kde.org
Wed Jul 18 03:05:02 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105604/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
Current parsing code for fo:border in KoParagraphStyle was not taking into account all the possible data variation in the value string to parse.
Attached fixes that. As a result "TestOpenDocumentStyle testParagraphStyle" does no longer fail on the attribute fo:border (only on style:shadow, fix coming as separate review request).
Also changes a bad test value (0cm, while only positive integer are allowed here).
Okay to backport to 2.5?
Diffs
-----
libs/kotext/styles/KoParagraphStyle.cpp 820da77
libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d0aadd4
Diff: http://git.reviewboard.kde.org/r/105604/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120718/7aaa051f/attachment.htm>
More information about the calligra-devel
mailing list