Review Request: fix parsing and writing of style:shadow value

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105606/#review16058
-----------------------------------------------------------


looks good to me. tempted to say ship it

- C. Boemann


On July 18, 2012, 2:10 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105606/
> -----------------------------------------------------------
> 
> (Updated July 18, 2012, 2:10 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> KoShadowStyle has small issues on loading and saving. This makes "TestOpenDocumentStyle testParagraphStyle" fail on the attribute "style:shadow".
> 
> Attached patch fixes that:
> * also allow color at end
> * do not write invalid color
> 
> With this patch and the "fix parsing of fo:border in KoParagraphStyle" one "TestOpenDocumentStyle testParagraphStyle" no longer fails on anything for me.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d0aadd4 
>   libs/odf/KoShadowStyle.cpp c12ee92 
> 
> Diff: http://git.reviewboard.kde.org/r/105606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120718/f90f8ca2/attachment.htm>