Review Request: fix parsing and writing of style:shadow value
Friedrich W. H. Kossebau
kossebau at kde.org
Wed Jul 18 03:10:30 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105606/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
KoShadowStyle has small issues on loading and saving. This makes "TestOpenDocumentStyle testParagraphStyle" fail on the attribute "style:shadow".
Attached patch fixes that:
* also allow color at end
* do not write invalid color
With this patch and the "fix parsing of fo:border in KoParagraphStyle" one "TestOpenDocumentStyle testParagraphStyle" no longer fails on anything for me.
Okay to backport to 2.5?
Diffs
-----
libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d0aadd4
libs/odf/KoShadowStyle.cpp c12ee92
Diff: http://git.reviewboard.kde.org/r/105606/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120718/a00eb488/attachment.htm>
More information about the calligra-devel
mailing list