Review Request: fix the "Print" services for Dolphin/Konqueror

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105363/#review15997
-----------------------------------------------------------

Ship it!


I actually think that a change like this doesn't really need a review... Thanks for picking up on this stuff!

- Boudewijn Rempt


On June 28, 2012, 9:25 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105363/
> -----------------------------------------------------------
> 
> (Updated June 28, 2012, 9:25 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Clean up quickprint services:
> * remove services with kchart and kformula
> * fix icon name from kde3 to proper Oxygen one
> * fix outdated program names
> * only installs a service file if the respective program is build
> 
> Sets as supported mimetype all mimetypes which are also listed as mimetypes in the programs' desktop files.
> Also tells about which program is used for printing (exception: krita), as the Calligra programs are not the only ones which could be used. Which is also true within Calligra programs, ODG can be printed with both Flow and Karbon.
> 
> Okay to backport to 2.5? Backported would only be the removal of the kchart/kformula services and the program + icon name fixes and the optional install. No filename changes and no new strings for 2.5.
> 
> 
> Diffs
> -----
> 
>   tools/quickprint/CMakeLists.txt b5ce904 
>   tools/quickprint/flow_konqi.desktop ea5bd36 
>   tools/quickprint/flow_print.desktop PRE-CREATION 
>   tools/quickprint/karbon_konqi.desktop eb26c52 
>   tools/quickprint/karbon_print.desktop PRE-CREATION 
>   tools/quickprint/kchart_konqi.desktop 01b999e 
>   tools/quickprint/kformula_konqi.desktop f8ff6c3 
>   tools/quickprint/kpresenter_konqi.desktop caa8812 
>   tools/quickprint/krita_konqi.desktop f0c9bd5 
>   tools/quickprint/krita_print.desktop PRE-CREATION 
>   tools/quickprint/kspread_konqi.desktop a646a47 
>   tools/quickprint/sheets_print.desktop PRE-CREATION 
>   tools/quickprint/stage_print.desktop PRE-CREATION 
>   tools/quickprint/words_konqi.desktop 08ee588 
>   tools/quickprint/words_print.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105363/diff/
> 
> 
> Testing
> -------
> 
> Printed a few files of supported mimetypes, at least once for any installed service description.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120717/c53a3fea/attachment.htm>