<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105363/">http://git.reviewboard.kde.org/r/105363/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I actually think that a change like this doesn't really need a review... Thanks for picking up on this stuff!</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On June 28th, 2012, 9:25 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 28, 2012, 9:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clean up quickprint services:
* remove services with kchart and kformula
* fix icon name from kde3 to proper Oxygen one
* fix outdated program names
* only installs a service file if the respective program is build
Sets as supported mimetype all mimetypes which are also listed as mimetypes in the programs' desktop files.
Also tells about which program is used for printing (exception: krita), as the Calligra programs are not the only ones which could be used. Which is also true within Calligra programs, ODG can be printed with both Flow and Karbon.
Okay to backport to 2.5? Backported would only be the removal of the kchart/kformula services and the program + icon name fixes and the optional install. No filename changes and no new strings for 2.5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Printed a few files of supported mimetypes, at least once for any installed service description.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tools/quickprint/CMakeLists.txt <span style="color: grey">(b5ce904)</span></li>
<li>tools/quickprint/flow_konqi.desktop <span style="color: grey">(ea5bd36)</span></li>
<li>tools/quickprint/flow_print.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/quickprint/karbon_konqi.desktop <span style="color: grey">(eb26c52)</span></li>
<li>tools/quickprint/karbon_print.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/quickprint/kchart_konqi.desktop <span style="color: grey">(01b999e)</span></li>
<li>tools/quickprint/kformula_konqi.desktop <span style="color: grey">(f8ff6c3)</span></li>
<li>tools/quickprint/kpresenter_konqi.desktop <span style="color: grey">(caa8812)</span></li>
<li>tools/quickprint/krita_konqi.desktop <span style="color: grey">(f0c9bd5)</span></li>
<li>tools/quickprint/krita_print.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/quickprint/kspread_konqi.desktop <span style="color: grey">(a646a47)</span></li>
<li>tools/quickprint/sheets_print.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/quickprint/stage_print.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/quickprint/words_konqi.desktop <span style="color: grey">(08ee588)</span></li>
<li>tools/quickprint/words_print.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>