Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

[Gopalakrishna Bhat]

> On July 16, 2012, 4:51 p.m., Thorsten Zachmann wrote:
> > The patch looks good and also the saved documents are valid now. However I noticed that clicking on links in TOC does not jump tp the selected index. This seems to be a regression to 2.5. If that is not related to your patch please commit.

It is definitely a regression from when I had last tried but not because of my patch.


- Gopalakrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105592/#review15971
-----------------------------------------------------------


On July 16, 2012, 1:51 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105592/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 1:51 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Currently we save all the anchors that point to a point internal to the document as text:bookmark-ref element irrespective of it being a text:a/text:bookmark-ref element while load.
> 
> This patch fixes this issue.
> 
> The changes in this patch fixes the toc releated calligratests failures
> interoperability/wordprocessing/oowriter/oow_toc_border.odt
> interoperability/wordprocessing/oowriter/oow_toc_center_aligned.odt
> interoperability/wordprocessing/oowriter/oow_toc_color.odt
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTableOfContentsGeneratorInfo.cpp 7d0e187 
>   libs/kotext/KoTextEditor_format.cpp f862719 
>   libs/kotext/opendocument/KoTextLoader.cpp d4272ed 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 717a2b3 
>   libs/kotext/styles/KoCharacterStyle.h a97811c 
>   libs/textlayout/ToCGenerator.cpp fcc521d 
> 
> Diff: http://git.reviewboard.kde.org/r/105592/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120716/2bfc9e74/attachment.htm>