<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105592/">http://git.reviewboard.kde.org/r/105592/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 16th, 2012, 4:51 p.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch looks good and also the saved documents are valid now. However I noticed that clicking on links in TOC does not jump tp the selected index. This seems to be a regression to 2.5. If that is not related to your patch please commit.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is definitely a regression from when I had last tried but not because of my patch.</pre>
<br />
<p>- Gopalakrishna</p>
<br />
<p>On July 16th, 2012, 1:51 p.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated July 16, 2012, 1:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently we save all the anchors that point to a point internal to the document as text:bookmark-ref element irrespective of it being a text:a/text:bookmark-ref element while load.
This patch fixes this issue.
The changes in this patch fixes the toc releated calligratests failures
interoperability/wordprocessing/oowriter/oow_toc_border.odt
interoperability/wordprocessing/oowriter/oow_toc_center_aligned.odt
interoperability/wordprocessing/oowriter/oow_toc_color.odt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTableOfContentsGeneratorInfo.cpp <span style="color: grey">(7d0e187)</span></li>
<li>libs/kotext/KoTextEditor_format.cpp <span style="color: grey">(f862719)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(d4272ed)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(717a2b3)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(a97811c)</span></li>
<li>libs/textlayout/ToCGenerator.cpp <span style="color: grey">(fcc521d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105592/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>