Review Request: fix icon of picture tool
Commit Hook
null at kde.org
Sun Jul 15 18:48:29 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105581/#review15906
-----------------------------------------------------------
This review has been submitted with commit 6f62d8ecbb7536052d34740ad251f3f0fc4fd143 by Friedrich W. H. Kossebau to branch master.
- Commit Hook
On July 15, 2012, 5:12 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105581/
> -----------------------------------------------------------
>
> (Updated July 15, 2012, 5:12 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> PictureToolFactory currently sets an icon name "pictureshape", for which no icon exists, so the "unknown" icon is displayed for the tool.
>
> But there is an icon "x-shape-image" (pics/oxygen/ox32-mimetype-x-shape-image.png), which is also used by PictureShapeFactory.
>
> Okay to backport to 2.5?
>
>
> Diffs
> -----
>
> plugins/pictureshape/PictureToolFactory.cpp cc47406
>
> Diff: http://git.reviewboard.kde.org/r/105581/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120715/b34187d1/attachment.htm>
More information about the calligra-devel
mailing list