Review Request: fix icon of picture tool

C. Boemann cbr at boemann.dk
Sun Jul 15 18:25:29 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105581/#review15903
-----------------------------------------------------------

Ship it!


It has my vote for sure

- C. Boemann


On July 15, 2012, 5:12 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105581/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 5:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> PictureToolFactory currently sets an icon name "pictureshape", for which no icon exists, so the "unknown" icon is displayed for the tool.
> 
> But there is an icon "x-shape-image" (pics/oxygen/ox32-mimetype-x-shape-image.png), which is also used by PictureShapeFactory.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   plugins/pictureshape/PictureToolFactory.cpp cc47406 
> 
> Diff: http://git.reviewboard.kde.org/r/105581/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120715/9ce10bf0/attachment.htm>


More information about the calligra-devel mailing list