Review Request: fix & improve template generation code

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105406/
-----------------------------------------------------------

(Updated July 13, 2012, 12:16 p.m.)


Review request for Calligra.


Changes
-------

Removed unneeded addition of resource dir (all are already added in the documentpart factories)
Made "Select..." button stick to "Custom" text again
Changed "Default" to "Preview" (as the term Default is not really obvious to the user)
added : to "Custom", not sure
removed some more unneeded code doing spacing and stretching


Description
-------

Another patch done on my quest to make thumbnails and previews working:

* fix loading of proper high-size icon (Desktop is usually not 128 pixels)
* fix preview generation to create 128x128 instead of 60x60 
* ensure saving of quadratic icons if preview or custom image is used
* move code duplication around call of KoTemplateCreateDia::createTemplate(...)
  into that method (would like an answer on the TODO added there)
* remove redundant label "Preview:" from dialog
* make Select... button in dialog to align at right side, instead of sticking to the string "Custom"

Ideally also gets backport to calligra/2.5...


Diffs (updated)
-----

  krita/ui/kis_view2.cpp 94ad9e4 
  libs/main/KoTemplate.cpp 99d76da 
  libs/main/KoTemplateCreateDia.h 4c4e478 
  libs/main/KoTemplateCreateDia.cpp 8cf0c40 
  plan/kptview.cpp ed28be3 
  sheets/part/View.cpp c6d6b3c 
  words/part/KWView.cpp 88a3de4 

Diff: http://git.reviewboard.kde.org/r/105406/diff/


Testing
-------

Oh yes... Created new templates via the dialog in Words, Krita & Sheets, with and without custom pictures of all kind.


Screenshots (updated)
-----------

Dialog with 2. patch
  http://git.reviewboard.kde.org/r/105406/s/631/


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120713/cc228e39/attachment.htm>