<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105406/">http://git.reviewboard.kde.org/r/105406/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 13, 2012, 12:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed unneeded addition of resource dir (all are already added in the documentpart factories)
Made "Select..." button stick to "Custom" text again
Changed "Default" to "Preview" (as the term Default is not really obvious to the user)
added : to "Custom", not sure
removed some more unneeded code doing spacing and stretching</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another patch done on my quest to make thumbnails and previews working:
* fix loading of proper high-size icon (Desktop is usually not 128 pixels)
* fix preview generation to create 128x128 instead of 60x60
* ensure saving of quadratic icons if preview or custom image is used
* move code duplication around call of KoTemplateCreateDia::createTemplate(...)
into that method (would like an answer on the TODO added there)
* remove redundant label "Preview:" from dialog
* make Select... button in dialog to align at right side, instead of sticking to the string "Custom"
Ideally also gets backport to calligra/2.5...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh yes... Created new templates via the dialog in Words, Krita & Sheets, with and without custom pictures of all kind.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/kis_view2.cpp <span style="color: grey">(94ad9e4)</span></li>
<li>libs/main/KoTemplate.cpp <span style="color: grey">(99d76da)</span></li>
<li>libs/main/KoTemplateCreateDia.h <span style="color: grey">(4c4e478)</span></li>
<li>libs/main/KoTemplateCreateDia.cpp <span style="color: grey">(8cf0c40)</span></li>
<li>plan/kptview.cpp <span style="color: grey">(ed28be3)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(c6d6b3c)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(88a3de4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105406/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105406/s/631/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/13/CreateTemplateDialog_400x100.png" style="border: 1px black solid;" alt="Dialog with 2. patch" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>