Review Request: fixes writing of "text:index-source-style_s_" instead of "text:index-source-style"

Friedrich W. H. Kossebau kossebau at kde.org
Fri Jul 13 00:44:24 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105541/
-----------------------------------------------------------

Review request for Calligra, C. Boemann and Smit Patel.


Description
-------

What a difference a "s" makes :) In IndexSourceStyle::saveOdf(...) at least the singular is wanted, the plural is correctly used by IndexSourceStyles::saveOdf(...).

Not sure if the loading code should have a workaround to also detect "text:index-source-styles" where just "text:index-source-style" is to be expected? Is that generated text, so skipping the reading due to broken token names is okay? How many documents have been generated with the bad token names?

Okay to backport to 2.5?


Diffs
-----

  libs/kotext/ToCBibGeneratorInfo.cpp 1d65790 

Diff: http://git.reviewboard.kde.org/r/105541/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120712/7e752340/attachment.htm>


More information about the calligra-devel mailing list