Review Request: fixes broken writing of number:text-style

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105530/#review15758
-----------------------------------------------------------


This review has been submitted with commit 19c29d582db971778b9780a2d9a876534dc451ff by Friedrich W. H. Kossebau to branch calligra/2.5.

- Commit Hook


On July 12, 2012, 10:03 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105530/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 10:03 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Seems the code in KoOdfNumberStyles::saveOdfTextStyle(...) never got finished after copying some template code.
> 
> Currently not only has strange code, but also writes garbage:
> * "number:text-style" instead of "number:text-content" used for variable position
> * suffix and prefix-suffix-extension written in wrong element
>     
> Attached patch fixes that (also avoids unneeded pass-by-copy for NumericStyleFormat type parameter elsewhere in sourcefile).
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoOdfNumberStyles.h 63ff036 
>   libs/odf/KoOdfNumberStyles.cpp 57e83c9 
> 
> Diff: http://git.reviewboard.kde.org/r/105530/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120712/ab60b34e/attachment.htm>