Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105390/
-----------------------------------------------------------

(Updated July 1, 2012, 10:09 a.m.)


Review request for Calligra, Yue Liu and Thorsten Zachmann.


Changes
-------

Sh*t, too many branches here, forgot to include changes to KoPADocument in the uploaded patch, and the cached thumbs confused me :/
Adding the reimplementation KoPADocument::generatePreview(...) only makes this patch effective.

Sorry, I hope you did not yet try the patch and wonder...


Description
-------

Currently the size of the thumbnails is not adapted to the format of the page, instead the icon contains empty white space on the sides if the page is not square. That results in bad previews in the filesystem browsers.

The patch fixes that by calculating the size of the preview image to just match the rendered area.
    
It also reduces code duplication by moving the identic implementations of thumbImage(...) and generateThumbnail(...) to the base class.
And removes the unused and never-defined method createPageThumbnail() from KPrNotes.


Diffs (updated)
-----

  libs/kopageapp/KoPADocument.h a19e382 
  libs/kopageapp/KoPADocument.cpp 83a148c 
  libs/kopageapp/KoPAMasterPage.h 9852973 
  libs/kopageapp/KoPAMasterPage.cpp 42e9065 
  libs/kopageapp/KoPAPage.h 6a81b04 
  libs/kopageapp/KoPAPage.cpp cd9c5f4 
  libs/kopageapp/KoPAPageBase.h b9a5961 
  libs/kopageapp/KoPAPageBase.cpp cd25030 
  libs/kopageapp/KoPAUtil.h b4ac6c4 
  libs/kopageapp/KoPAUtil.cpp 5353151 
  stage/part/KPrNotes.h 28ee984 

Diff: http://git.reviewboard.kde.org/r/105390/diff/


Testing
-------

Cleared the thumbnail cache in ~/.thumbnails and enjoyed better thumbnails after the patch :) E.g. when browsing the templates.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120701/d2891e4f/attachment.htm>