<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105390/">http://git.reviewboard.kde.org/r/105390/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Yue Liu and Thorsten Zachmann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 1, 2012, 10:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sh*t, too many branches here, forgot to include changes to KoPADocument in the uploaded patch, and the cached thumbs confused me :/
Adding the reimplementation KoPADocument::generatePreview(...) only makes this patch effective.
Sorry, I hope you did not yet try the patch and wonder...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently the size of the thumbnails is not adapted to the format of the page, instead the icon contains empty white space on the sides if the page is not square. That results in bad previews in the filesystem browsers.
The patch fixes that by calculating the size of the preview image to just match the rendered area.
It also reduces code duplication by moving the identic implementations of thumbImage(...) and generateThumbnail(...) to the base class.
And removes the unused and never-defined method createPageThumbnail() from KPrNotes.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cleared the thumbnail cache in ~/.thumbnails and enjoyed better thumbnails after the patch :) E.g. when browsing the templates.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPADocument.h <span style="color: grey">(a19e382)</span></li>
<li>libs/kopageapp/KoPADocument.cpp <span style="color: grey">(83a148c)</span></li>
<li>libs/kopageapp/KoPAMasterPage.h <span style="color: grey">(9852973)</span></li>
<li>libs/kopageapp/KoPAMasterPage.cpp <span style="color: grey">(42e9065)</span></li>
<li>libs/kopageapp/KoPAPage.h <span style="color: grey">(6a81b04)</span></li>
<li>libs/kopageapp/KoPAPage.cpp <span style="color: grey">(cd9c5f4)</span></li>
<li>libs/kopageapp/KoPAPageBase.h <span style="color: grey">(b9a5961)</span></li>
<li>libs/kopageapp/KoPAPageBase.cpp <span style="color: grey">(cd25030)</span></li>
<li>libs/kopageapp/KoPAUtil.h <span style="color: grey">(b4ac6c4)</span></li>
<li>libs/kopageapp/KoPAUtil.cpp <span style="color: grey">(5353151)</span></li>
<li>stage/part/KPrNotes.h <span style="color: grey">(28ee984)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105390/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>