Review Request: Fix detection of marble method.

Thorsten Zachmann t.zachmann at zagge.de
Fri Jan 27 17:36:03 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103791/#review10156
-----------------------------------------------------------

Ship it!


Please commit after fixing the error I pointed out.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/103791/#comment8356>

    CheckCxxSourceCompiles needs to be changed to CheckCXXSourceCompiles so that it works on linux also


- Thorsten Zachmann


On Jan. 25, 2012, 1:05 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103791/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2012, 1:05 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Marble changed addMarbleWidget method name setMarbleWidget, but calligra's cmake file detects this change using the grep command. This does not work under legacy Operating Systems where there's no grep command. This patch changes its detection by using CMake's CHECK_CXX_SOURCE_COMPILES macro.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d394f9c 
> 
> Diff: http://git.reviewboard.kde.org/r/103791/diff/diff
> 
> 
> Testing
> -------
> 
> Tested under MSVC 2010 32bit, Windows 7 64bit machine.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120127/e3cc9244/attachment.htm>


More information about the calligra-devel mailing list