Review Request: Fix detection of marble method.

Andrius da Costa Ribas andriusmao at gmail.com
Wed Jan 25 13:05:39 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103791/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Marble changed addMarbleWidget method name setMarbleWidget, but calligra's cmake file detects this change using the grep command. This does not work under legacy Operating Systems where there's no grep command. This patch changes its detection by using CMake's CHECK_CXX_SOURCE_COMPILES macro.


Diffs
-----

  CMakeLists.txt d394f9c 

Diff: http://git.reviewboard.kde.org/r/103791/diff/diff


Testing
-------

Tested under MSVC 2010 32bit, Windows 7 64bit machine.


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120125/d3a2f53e/attachment.htm>


More information about the calligra-devel mailing list