Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

[C. Boemann]

> On Jan. 15, 2012, 8:17 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/SimpleCharacterWidget.cpp, line 131
> > <http://git.reviewboard.kde.org/r/103677/diff/4/?file=46799#file46799line131>
> >
> >     = block.charformat
> >
> 
> Pierre Stirnweiss wrote:
>     The simpleCharacterWidget doesn't know anything about the current block. However, it seems to work like that.

No it does not work. I have a simple file where i can see it doesn't work. So we need to figure out a way to get access to this info


> On Jan. 15, 2012, 8:17 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/SimpleCharacterWidget.ui, line 114
> > <http://git.reviewboard.kde.org/r/103677/diff/4/?file=46800#file46800line114>
> >
> >     oooh you removed the SpecialButton too
> >     
> >     please revert that part
> 
> Pierre Stirnweiss wrote:
>     Huh, I am not sure I follow you here, the whole exercise is to replace the SpecialButton.

sorry i misread, I thought it was the specualspacer you had removed

my bad


> On Jan. 15, 2012, 8:17 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/SimpleParagraphWidget.ui, line 121
> > <http://git.reviewboard.kde.org/r/103677/diff/4/?file=46803#file46803line121>
> >
> >     please dont remove the special button
> >     it's very needed
> 
> Pierre Stirnweiss wrote:
>     Idem.

Once again I apologize


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103677/#review9842
-----------------------------------------------------------


On Jan. 15, 2012, 7:41 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103677/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2012, 7:41 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Merge request.
> Merge branch textshape_stylesWidget_pierreSt into master.
> The branch provides a replacement for the style selection widgets. The new provided widgets are a subclass of QComboBox.
> They provide a style preview both in the main area and in the dropdown menu.
> The dropdown menu provides a "show style manager" button, which call the whole style management dialog.
> The dropdown also provides a "delete style" button, although this is for the moment disabled/commented out, because deleting a style is not currently really supported.
> The combo also allows to create a style based on the current text format if it does not correspond to the original style (ie. the user changed a property).
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor.h 0fc4ff4 
>   libs/kotext/KoTextEditor.cpp 3ef31d6 
>   libs/kotext/styles/KoCharacterStyle.h 898ba43 
>   libs/kotext/styles/KoCharacterStyle.cpp e575b0d 
>   libs/kotext/styles/KoParagraphStyle.h 12ab672 
>   libs/textlayout/CMakeLists.txt af6d64a 
>   libs/textlayout/FrameIterator.h c73d580 
>   libs/textlayout/KoStyleThumbnailer.h 8645089 
>   libs/textlayout/KoStyleThumbnailer.cpp 3529bbb 
>   plugins/textshape/CMakeLists.txt fad7c04 
>   plugins/textshape/TextTool.h 17a687b 
>   plugins/textshape/TextTool.cpp 3ba9d33 
>   plugins/textshape/dialogs/SimpleCharacterWidget.h ad944a5 
>   plugins/textshape/dialogs/SimpleCharacterWidget.cpp 6b2bb66 
>   plugins/textshape/dialogs/SimpleCharacterWidget.ui e4f6d3b 
>   plugins/textshape/dialogs/SimpleParagraphWidget.h bc167b4 
>   plugins/textshape/dialogs/SimpleParagraphWidget.cpp cbfacfe 
>   plugins/textshape/dialogs/SimpleParagraphWidget.ui b2e9adf 
>   plugins/textshape/dialogs/StylesCombo.h PRE-CREATION 
>   plugins/textshape/dialogs/StylesCombo.cpp PRE-CREATION 
>   plugins/textshape/dialogs/StylesComboPreview.h PRE-CREATION 
>   plugins/textshape/dialogs/StylesComboPreview.cpp PRE-CREATION 
>   plugins/textshape/dialogs/StylesDelegate.h f5d216f 
>   plugins/textshape/dialogs/StylesDelegate.cpp d1021f5 
>   plugins/textshape/dialogs/StylesModel.h dbd17b4 
>   plugins/textshape/dialogs/StylesModel.cpp 94deb24 
>   plugins/textshape/dialogs/StylesWidget.cpp 4f31a01 
>   plugins/textshape/dialogs/TableOfContentsStyleModel.cpp 48ee7c3 
> 
> Diff: http://git.reviewboard.kde.org/r/103677/diff/diff
> 
> 
> Testing
> -------
> 
> The functionality exclusively linked to the comboBox seems to be working properly. Some defects have been identified (like no paragraph style is selected at startup), but these are actually outside the scope of this widget and affecting the current widget also.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120116/5aec68ee/attachment.htm>