Review Request: line heights of empty lines

[Matus Uzak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103664/#review9769
-----------------------------------------------------------

Ship it!


I do like the comments.  As we already discussed the behavior is correct.

I used cstester to test the patch together with a patch for libmsooxml which removes the workaround that altered the font-size of the line-break.  The workaround changed the font-size of a line-break to minimum to not affected the line-height of the next line.  I tested against a commit where I reverted [1] from the master.  Looks really good! We are compatible with both LO and MS Office.  The only problem i found is some strange placement of lines and incorrect line-height in case empty <text:span/> elements are in the file.  But this can be analyzed and fixed later.

I did not check the code itself, but it should be Ok according to tests result.

[1] http://quickgit.kde.org/index.php?p=calligra.git&a=commit&h=d539c669c79eb83caa827025eabd1ef737eb85b5

- Matus Uzak


On Jan. 9, 2012, 11:27 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103664/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 11:27 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Before newyear i removed some characters that shouldn't be there when we load
> 
> However that broke lineheights of empty lines. I have now analysed LO/OO and coded the same behaviour into 
> Calligra. The filters will have to follow, but at least the last line thing is the same as the filters do
> 
> Anyway here is the commit msg:
> 
>     Make the line heights work like LibreOffice/OpenOffice when in combination with line breaks
>         1) a blank line is affected by the line break after
>         2) a line with contents is not affected by the linebreak
>         3) following line is never affected by the line break
>         4) a final line if blank can have it's height specified by a special textstyle
> 
> 
> Diffs
> -----
> 
>   libs/kotext/opendocument/KoTextLoader.cpp eb9c677 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 0d04bcb 
>   libs/kotext/styles/KoCharacterStyle.h c13972c 
>   libs/kotext/styles/KoParagraphStyle.h bccc252 
>   libs/textlayout/KoTextLayoutArea.cpp aef7357 
>   libs/textlayout/tests/TestBlockLayout.h 1286629 
>   libs/textlayout/tests/TestBlockLayout.cpp 5216d78 
> 
> Diff: http://git.reviewboard.kde.org/r/103664/diff/diff
> 
> 
> Testing
> -------
> 
> I've loaded and saved a file and roundtrips
> 
> I've added a unit test plus done manual testing
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120112/64048ae2/attachment.htm>