<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103664/">http://git.reviewboard.kde.org/r/103664/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do like the comments. As we already discussed the behavior is correct.
I used cstester to test the patch together with a patch for libmsooxml which removes the workaround that altered the font-size of the line-break. The workaround changed the font-size of a line-break to minimum to not affected the line-height of the next line. I tested against a commit where I reverted [1] from the master. Looks really good! We are compatible with both LO and MS Office. The only problem i found is some strange placement of lines and incorrect line-height in case empty <text:span/> elements are in the file. But this can be analyzed and fixed later.
I did not check the code itself, but it should be Ok according to tests result.
[1] http://quickgit.kde.org/index.php?p=calligra.git&a=commit&h=d539c669c79eb83caa827025eabd1ef737eb85b5</pre>
<br />
<p>- Matus</p>
<br />
<p>On January 9th, 2012, 11:27 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2012, 11:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before newyear i removed some characters that shouldn't be there when we load
However that broke lineheights of empty lines. I have now analysed LO/OO and coded the same behaviour into
Calligra. The filters will have to follow, but at least the last line thing is the same as the filters do
Anyway here is the commit msg:
Make the line heights work like LibreOffice/OpenOffice when in combination with line breaks
1) a blank line is affected by the line break after
2) a line with contents is not affected by the linebreak
3) following line is never affected by the line break
4) a final line if blank can have it's height specified by a special textstyle
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've loaded and saved a file and roundtrips
I've added a unit test plus done manual testing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(eb9c677)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(0d04bcb)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(c13972c)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(bccc252)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(aef7357)</span></li>
<li>libs/textlayout/tests/TestBlockLayout.h <span style="color: grey">(1286629)</span></li>
<li>libs/textlayout/tests/TestBlockLayout.cpp <span style="color: grey">(5216d78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103664/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>