Review Request: Add support for footnote's continuation
C. Boemann
cbr at boemann.dk
Thu Feb 23 09:15:04 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104043/#review10823
-----------------------------------------------------------
Trying it out interactively it's not up to the job yet. It writes text on top of text and doesn't create a new page.
We are also too close to RC and this is really a new feature, so I'm sory but this will have to wait until 2.5
Contact me on irc for details about what the problems I see are.
libs/textlayout/KoTextLayoutArea.cpp
<http://git.reviewboard.kde.org/r/104043/#comment8770>
i'm not sure the layout logic is strong enough here.
plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/104043/#comment8769>
- C. Boemann
On Feb. 22, 2012, 7:05 p.m., Brijesh Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104043/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2012, 7:05 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> This patch adds a feature, continuation of footnotes on next page when there's no space to fit on the same page, as part of footnote's configuration.
>
>
> Diffs
> -----
>
> libs/odf/KoOdfNotesConfiguration.cpp 7a2ca81
> libs/textlayout/KoTextDocumentLayout.cpp 17192cb
> libs/textlayout/KoTextLayoutArea.h f919170
> libs/textlayout/KoTextLayoutArea.cpp 8700f11
> libs/textlayout/KoTextLayoutEndNotesArea.cpp c145e6e
> libs/textlayout/KoTextLayoutNoteArea.h 2b5178b
> libs/textlayout/KoTextLayoutNoteArea.cpp 92d63c6
> plugins/textshape/ReferencesTool.cpp 025b650
> plugins/textshape/dialogs/NotesConfigurationDialog.cpp 4e6f6d3
>
> Diff: http://git.reviewboard.kde.org/r/104043/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brijesh Patel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120223/4966ba66/attachment.htm>
More information about the calligra-devel
mailing list