<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104043/">http://git.reviewboard.kde.org/r/104043/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Trying it out interactively it's not up to the job yet. It writes text on top of text and doesn't create a new page.
We are also too close to RC and this is really a new feature, so I'm sory but this will have to wait until 2.5
Contact me on irc for details about what the problems I see are.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104043/diff/1/?file=50739#file50739line1842" style="color: black; font-weight: bold; text-decoration: underline;">libs/textlayout/KoTextLayoutArea.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoTextLayoutArea::findFootNotes(QTextBlock block, const QTextLine &line)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1796</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">footNoteArea</span><span class="o">-></span><span class="n">layout</span><span class="p">(</span><span class="o">&</span><span class="n">iter</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1842</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">footNoteArea</span><span class="o">-></span><span class="n">setReferenceRect</span><span class="p">(</span><span class="n">left</span><span class="p">(),</span> <span class="n">right</span><span class="p">(),</span> <span class="mi">0</span><span class="p">,</span> <span class="n">maximumAllowedBottom</span><span class="p">()</span> <span class="o">-</span> <span class="n">line</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span class="o">-</span> <span class="n">m_y</span> <span class="o">+</span> <span class="n">offset</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i'm not sure the layout logic is strong enough here.
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104043/diff/1/?file=50743#file50743line124" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/ReferencesTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ReferencesTool::createActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">124</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Configure"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">124</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Configure<span class="hl"> the notes</span>"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"></pre>
</div>
<br />
<p>- C.</p>
<br />
<p>On February 22nd, 2012, 7:05 p.m., Brijesh Patel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Brijesh Patel.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2012, 7:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a feature, continuation of footnotes on next page when there's no space to fit on the same page, as part of footnote's configuration.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/odf/KoOdfNotesConfiguration.cpp <span style="color: grey">(7a2ca81)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: grey">(17192cb)</span></li>
<li>libs/textlayout/KoTextLayoutArea.h <span style="color: grey">(f919170)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(8700f11)</span></li>
<li>libs/textlayout/KoTextLayoutEndNotesArea.cpp <span style="color: grey">(c145e6e)</span></li>
<li>libs/textlayout/KoTextLayoutNoteArea.h <span style="color: grey">(2b5178b)</span></li>
<li>libs/textlayout/KoTextLayoutNoteArea.cpp <span style="color: grey">(92d63c6)</span></li>
<li>plugins/textshape/ReferencesTool.cpp <span style="color: grey">(025b650)</span></li>
<li>plugins/textshape/dialogs/NotesConfigurationDialog.cpp <span style="color: grey">(4e6f6d3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>