Review Request: Added Microsoft Visio and Works import filters, updated WordPerfect Document/Graphics import filters

Sun Feb 19 10:05:24 GMT 2012

> On Feb. 19, 2012, 9:49 a.m., C. Boemann wrote:
> > I'd say such depenencies fall under new features, but on the other hand I can also see the benefit.
> > 
> > I'm back from munich wednesday and will the be able to tell the release readiness state of Words. If we are to say create a release branch on friday and an RC next friday, then I tink your patch is too late, but if we tag a beta on friday, then maybe it would be possible to sneak it in.
> > 
> > Either way let's not decide until end of week.

I didn't mean add it to 2.4 immediately, I can wait for 2.5. Just post it out for a review:)

- Yue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104020/#review10741
-----------------------------------------------------------

On Feb. 19, 2012, 2:42 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104020/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2012, 2:42 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Introduecd two new dependency, libwps and libvisio (not packaged by most distro yet). Updated wpd import filter so no Qt3Support needed anymore, disabled wpd export filter, updated wpg import filter to make it generates odg document directly(previously it generates svg document), added a new library writerperfect under filters/writerperfect where all of the four filters above use.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindLibVisio.cmake PRE-CREATION 
>   cmake/modules/FindLibWPS.cmake PRE-CREATION 
>   filters/CMakeLists.txt 3d04c1e 
>   filters/flow/CMakeLists.txt 55369f1 
>   filters/flow/visio/CMakeLists.txt PRE-CREATION 
>   filters/flow/visio/import/CMakeLists.txt PRE-CREATION 
>   filters/flow/visio/import/VSDXImport.h PRE-CREATION 
>   filters/flow/visio/import/VSDXImport.cpp PRE-CREATION 
>   filters/flow/visio/import/flow_vsdx_import.desktop PRE-CREATION 
>   filters/karbon/wpg/CMakeLists.txt ccf4689 
>   filters/karbon/wpg/WPGImport.h 8390dc3 
>   filters/karbon/wpg/WPGImport.cpp bfe0a93 
>   filters/karbon/wpg/karbon_wpg_import.desktop 91b328d 
>   filters/words/CMakeLists.txt ba9fdc0 
>   filters/words/wordperfect/CMakeLists.txt 43f54ac 
>   filters/words/wordperfect/import/CMakeLists.txt 141508b 
>   filters/words/wordperfect/import/DocumentElement.hxx 1ab43f5 
>   filters/words/wordperfect/import/DocumentElement.cxx 4f0428a 
>   filters/words/wordperfect/import/DocumentHandler.hxx a2fe2fa 
>   filters/words/wordperfect/import/FilterInternal.hxx 5161595 
>   filters/words/wordperfect/import/FontStyle.hxx 04ecfd1 
>   filters/words/wordperfect/import/FontStyle.cxx b926ccd 
>   filters/words/wordperfect/import/ListStyle.hxx c25ee63 
>   filters/words/wordperfect/import/ListStyle.cxx 17d150e 
>   filters/words/wordperfect/import/PageSpan.hxx f3e6d8d 
>   filters/words/wordperfect/import/PageSpan.cxx 759d43d 
>   filters/words/wordperfect/import/SectionStyle.hxx 9508a88 
>   filters/words/wordperfect/import/SectionStyle.cxx beda648 
>   filters/words/wordperfect/import/Style.hxx 9a57edc 
>   filters/words/wordperfect/import/TableStyle.hxx e532118 
>   filters/words/wordperfect/import/TableStyle.cxx 9c5692b 
>   filters/words/wordperfect/import/TextRunStyle.hxx 2b2eb63 
>   filters/words/wordperfect/import/TextRunStyle.cxx 7d9914e 
>   filters/words/wordperfect/import/WPDImport.h PRE-CREATION 
>   filters/words/wordperfect/import/WPDImport.cpp PRE-CREATION 
>   filters/words/wordperfect/import/WordPerfectCollector.hxx 561796f 
>   filters/words/wordperfect/import/WordPerfectCollector.cxx 7c630fe 
>   filters/words/wordperfect/import/WriterProperties.hxx a3c6433 
>   filters/words/wordperfect/import/words_wp_import.desktop d2fbc73 
>   filters/words/wordperfect/import/words_wpd_import.desktop PRE-CREATION 
>   filters/words/wordperfect/import/wordsfilter.h 9d6865b 
>   filters/words/wordperfect/import/wordsfilter.cpp 4f9baa6 
>   filters/words/wordperfect/import/wpimport.h abc93fb 
>   filters/words/wordperfect/import/wpimport.cc 43b7783 
>   filters/words/wordperfect/status.html a12f6c8 
>   filters/words/wordperfect/status_old.html 4e176d1 
>   filters/words/works/CMakeLists.txt PRE-CREATION 
>   filters/words/works/import/CMakeLists.txt PRE-CREATION 
>   filters/words/works/import/WPSImport.h PRE-CREATION 
>   filters/words/works/import/WPSImport.cpp PRE-CREATION 
>   filters/words/works/import/words_wps_import.desktop PRE-CREATION 
>   filters/writerperfect/CMakeLists.txt PRE-CREATION 
>   filters/writerperfect/DiskDocumentHandler.hxx PRE-CREATION 
>   filters/writerperfect/DiskDocumentHandler.cxx PRE-CREATION 
>   filters/writerperfect/DocumentElement.hxx PRE-CREATION 
>   filters/writerperfect/DocumentElement.cxx PRE-CREATION 
>   filters/writerperfect/FemtoZip.hxx PRE-CREATION 
>   filters/writerperfect/FemtoZip.cxx PRE-CREATION 
>   filters/writerperfect/FilterInternal.hxx PRE-CREATION 
>   filters/writerperfect/FontStyle.hxx PRE-CREATION 
>   filters/writerperfect/FontStyle.cxx PRE-CREATION 
>   filters/writerperfect/InternalHandler.hxx PRE-CREATION 
>   filters/writerperfect/InternalHandler.cxx PRE-CREATION 
>   filters/writerperfect/ListStyle.hxx PRE-CREATION 
>   filters/writerperfect/ListStyle.cxx PRE-CREATION 
>   filters/writerperfect/OdfDocumentHandler.hxx PRE-CREATION 
>   filters/writerperfect/OdgGenerator.hxx PRE-CREATION 
>   filters/writerperfect/OdgGenerator.cxx PRE-CREATION 
>   filters/writerperfect/OdtGenerator.hxx PRE-CREATION 
>   filters/writerperfect/OdtGenerator.cxx PRE-CREATION 
>   filters/writerperfect/OutputFileHelper.hxx PRE-CREATION 
>   filters/writerperfect/OutputFileHelper.cxx PRE-CREATION 
>   filters/writerperfect/PageSpan.hxx PRE-CREATION 
>   filters/writerperfect/PageSpan.cxx PRE-CREATION 
>   filters/writerperfect/SectionStyle.hxx PRE-CREATION 
>   filters/writerperfect/SectionStyle.cxx PRE-CREATION 
>   filters/writerperfect/StdOutHandler.hxx PRE-CREATION 
>   filters/writerperfect/StdOutHandler.cxx PRE-CREATION 
>   filters/writerperfect/Style.hxx PRE-CREATION 
>   filters/writerperfect/TableStyle.hxx PRE-CREATION 
>   filters/writerperfect/TableStyle.cxx PRE-CREATION 
>   filters/writerperfect/TextRunStyle.hxx PRE-CREATION 
>   filters/writerperfect/TextRunStyle.cxx PRE-CREATION 
>   filters/writerperfect/WriterProperties.hxx PRE-CREATION 
>   filters/writerperfect/writerperfect_export.h PRE-CREATION 
>   flow/part/flow.desktop 53d93fa 
>   flow/part/flowpart.desktop f1e3d4c 
> 
> Diff: http://git.reviewboard.kde.org/r/104020/diff/
> 
> 
> Testing
> -------
> 
> vsd to odg conversion runs well through calligraconverter, but the visio format cannot be seen from import dialog in Flow, I'm not sure where need to add those strings...
> new wpd/wpg/wps filters are not tested for I don't have any test document in those formats but the workflows are similar to vsd filter so they should work.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120219/d0f5f055/attachment.htm>