<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104020/">http://git.reviewboard.kde.org/r/104020/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 19th, 2012, 9:49 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd say such depenencies fall under new features, but on the other hand I can also see the benefit.
I'm back from munich wednesday and will the be able to tell the release readiness state of Words. If we are to say create a release branch on friday and an RC next friday, then I tink your patch is too late, but if we tag a beta on friday, then maybe it would be possible to sneak it in.
Either way let's not decide until end of week.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't mean add it to 2.4 immediately, I can wait for 2.5. Just post it out for a review:)</pre>
<br />
<p>- Yue</p>
<br />
<p>On February 19th, 2012, 2:42 a.m., Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2012, 2:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduecd two new dependency, libwps and libvisio (not packaged by most distro yet). Updated wpd import filter so no Qt3Support needed anymore, disabled wpd export filter, updated wpg import filter to make it generates odg document directly(previously it generates svg document), added a new library writerperfect under filters/writerperfect where all of the four filters above use.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">vsd to odg conversion runs well through calligraconverter, but the visio format cannot be seen from import dialog in Flow, I'm not sure where need to add those strings...
new wpd/wpg/wps filters are not tested for I don't have any test document in those formats but the workflows are similar to vsd filter so they should work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindLibVisio.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindLibWPS.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(3d04c1e)</span></li>
<li>filters/flow/CMakeLists.txt <span style="color: grey">(55369f1)</span></li>
<li>filters/flow/visio/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/visio/import/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/visio/import/VSDXImport.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/visio/import/VSDXImport.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/flow/visio/import/flow_vsdx_import.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/wpg/CMakeLists.txt <span style="color: grey">(ccf4689)</span></li>
<li>filters/karbon/wpg/WPGImport.h <span style="color: grey">(8390dc3)</span></li>
<li>filters/karbon/wpg/WPGImport.cpp <span style="color: grey">(bfe0a93)</span></li>
<li>filters/karbon/wpg/karbon_wpg_import.desktop <span style="color: grey">(91b328d)</span></li>
<li>filters/words/CMakeLists.txt <span style="color: grey">(ba9fdc0)</span></li>
<li>filters/words/wordperfect/CMakeLists.txt <span style="color: grey">(43f54ac)</span></li>
<li>filters/words/wordperfect/import/CMakeLists.txt <span style="color: grey">(141508b)</span></li>
<li>filters/words/wordperfect/import/DocumentElement.hxx <span style="color: grey">(1ab43f5)</span></li>
<li>filters/words/wordperfect/import/DocumentElement.cxx <span style="color: grey">(4f0428a)</span></li>
<li>filters/words/wordperfect/import/DocumentHandler.hxx <span style="color: grey">(a2fe2fa)</span></li>
<li>filters/words/wordperfect/import/FilterInternal.hxx <span style="color: grey">(5161595)</span></li>
<li>filters/words/wordperfect/import/FontStyle.hxx <span style="color: grey">(04ecfd1)</span></li>
<li>filters/words/wordperfect/import/FontStyle.cxx <span style="color: grey">(b926ccd)</span></li>
<li>filters/words/wordperfect/import/ListStyle.hxx <span style="color: grey">(c25ee63)</span></li>
<li>filters/words/wordperfect/import/ListStyle.cxx <span style="color: grey">(17d150e)</span></li>
<li>filters/words/wordperfect/import/PageSpan.hxx <span style="color: grey">(f3e6d8d)</span></li>
<li>filters/words/wordperfect/import/PageSpan.cxx <span style="color: grey">(759d43d)</span></li>
<li>filters/words/wordperfect/import/SectionStyle.hxx <span style="color: grey">(9508a88)</span></li>
<li>filters/words/wordperfect/import/SectionStyle.cxx <span style="color: grey">(beda648)</span></li>
<li>filters/words/wordperfect/import/Style.hxx <span style="color: grey">(9a57edc)</span></li>
<li>filters/words/wordperfect/import/TableStyle.hxx <span style="color: grey">(e532118)</span></li>
<li>filters/words/wordperfect/import/TableStyle.cxx <span style="color: grey">(9c5692b)</span></li>
<li>filters/words/wordperfect/import/TextRunStyle.hxx <span style="color: grey">(2b2eb63)</span></li>
<li>filters/words/wordperfect/import/TextRunStyle.cxx <span style="color: grey">(7d9914e)</span></li>
<li>filters/words/wordperfect/import/WPDImport.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wordperfect/import/WPDImport.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wordperfect/import/WordPerfectCollector.hxx <span style="color: grey">(561796f)</span></li>
<li>filters/words/wordperfect/import/WordPerfectCollector.cxx <span style="color: grey">(7c630fe)</span></li>
<li>filters/words/wordperfect/import/WriterProperties.hxx <span style="color: grey">(a3c6433)</span></li>
<li>filters/words/wordperfect/import/words_wp_import.desktop <span style="color: grey">(d2fbc73)</span></li>
<li>filters/words/wordperfect/import/words_wpd_import.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wordperfect/import/wordsfilter.h <span style="color: grey">(9d6865b)</span></li>
<li>filters/words/wordperfect/import/wordsfilter.cpp <span style="color: grey">(4f9baa6)</span></li>
<li>filters/words/wordperfect/import/wpimport.h <span style="color: grey">(abc93fb)</span></li>
<li>filters/words/wordperfect/import/wpimport.cc <span style="color: grey">(43b7783)</span></li>
<li>filters/words/wordperfect/status.html <span style="color: grey">(a12f6c8)</span></li>
<li>filters/words/wordperfect/status_old.html <span style="color: grey">(4e176d1)</span></li>
<li>filters/words/works/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/works/import/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/works/import/WPSImport.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/works/import/WPSImport.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/works/import/words_wps_import.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/DiskDocumentHandler.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/DiskDocumentHandler.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/DocumentElement.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/DocumentElement.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/FemtoZip.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/FemtoZip.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/FilterInternal.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/FontStyle.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/FontStyle.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/InternalHandler.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/InternalHandler.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/ListStyle.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/ListStyle.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/OdfDocumentHandler.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/OdgGenerator.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/OdgGenerator.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/OdtGenerator.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/OdtGenerator.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/OutputFileHelper.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/OutputFileHelper.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/PageSpan.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/PageSpan.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/SectionStyle.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/SectionStyle.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/StdOutHandler.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/StdOutHandler.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/Style.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/TableStyle.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/TableStyle.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/TextRunStyle.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/TextRunStyle.cxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/WriterProperties.hxx <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/writerperfect/writerperfect_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>flow/part/flow.desktop <span style="color: grey">(53d93fa)</span></li>
<li>flow/part/flowpart.desktop <span style="color: grey">(f1e3d4c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104020/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>