Review Request: This patch is to update the calligra to enable/disable the next/previous slide button for presentation depending on user is on first or last slide

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103846/#review10291
-----------------------------------------------------------

Ship it!


Fix the small issue below, and ship it :)
(dont forget to say REVIEW: 103846 in the commit, that will automatically mark this review as submitted)


active/src/CAPresentationHandler.cpp
<http://git.reviewboard.kde.org/r/103846/#comment8478>

    instead of doing the emit two times, just do it once before doUpdateActivePage (outside the if block, not inside).


- Shantanu Tushar Jha


On Feb. 2, 2012, 5:29 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103846/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2012, 5:29 p.m.)
> 
> 
> Review request for Calligra and Shantanu Tushar Jha.
> 
> 
> Description
> -------
> 
> The following changes were made in this patch:
> 1) Add the total number of slide number along with the current slide number.
> 2) If the user views the first slide, hide the previous button(left button).
> 3) If the user views the last slide, hide the next button( right button).
> 
> 
> Diffs
> -----
> 
>   active/qml/PresentationLeftToolbar.qml bfdcc91 
>   active/qml/PresentationRightToolbar.qml 24ed0b2 
>   active/qml/PresentationTopToolbar.qml 7ebfec9 
>   active/src/CAPresentationHandler.h 1621be5 
>   active/src/CAPresentationHandler.cpp b5b1aea 
> 
> Diff: http://git.reviewboard.kde.org/r/103846/diff/diff
> 
> 
> Testing
> -------
> 
> 1) When user launches the CA with the presentation file open, he/she sees the left button disabled if he/she is on the first slide of the presentation. As user moves on to next slide(s) the previous slide button is displayed.
> 2) When user reaches the last slide, he/she sees the right button disabled. And cannot move to next slide( because its already the last slide). As the user moves to previous slide(s) the next slide button is displayed.
> 3) Checked the total slide number which is visible throughout the slide.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120202/385ed502/attachment.htm>