<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103846/">http://git.reviewboard.kde.org/r/103846/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix the small issue below, and ship it :)
(dont forget to say REVIEW: 103846 in the commit, that will automatically mark this review as submitted)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103846/diff/2/?file=48519#file48519line144" style="color: black; font-weight: bold; text-decoration: underline;">active/src/CAPresentationHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QStringList CAPresentationHandler::supportedMimetypes()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">144</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">emit</span> <span class="n">currentSlideNumChanged</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">instead of doing the emit two times, just do it once before doUpdateActivePage (outside the if block, not inside).</pre>
</div>
<br />
<p>- Shantanu Tushar</p>
<br />
<p>On February 2nd, 2012, 5:29 p.m., Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Shantanu Tushar Jha.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2012, 5:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following changes were made in this patch:
1) Add the total number of slide number along with the current slide number.
2) If the user views the first slide, hide the previous button(left button).
3) If the user views the last slide, hide the next button( right button).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) When user launches the CA with the presentation file open, he/she sees the left button disabled if he/she is on the first slide of the presentation. As user moves on to next slide(s) the previous slide button is displayed.
2) When user reaches the last slide, he/she sees the right button disabled. And cannot move to next slide( because its already the last slide). As the user moves to previous slide(s) the next slide button is displayed.
3) Checked the total slide number which is visible throughout the slide.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/qml/PresentationLeftToolbar.qml <span style="color: grey">(bfdcc91)</span></li>
<li>active/qml/PresentationRightToolbar.qml <span style="color: grey">(24ed0b2)</span></li>
<li>active/qml/PresentationTopToolbar.qml <span style="color: grey">(7ebfec9)</span></li>
<li>active/src/CAPresentationHandler.h <span style="color: grey">(1621be5)</span></li>
<li>active/src/CAPresentationHandler.cpp <span style="color: grey">(b5b1aea)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103846/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>