Review Request: Make the epub filter handle math formulas

[Inge Wallin]

> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote:
> > there is a few places where you have:
> > 
> > if ()
> > {
> > 
> > and one place where there is no {} after if
> > 
> > other than that I've not looked yet - I assume you want moji to review

The 

if ()
{

construct is only used where the test is >1 line.  If I put the { at the end of the line, the first statement inside the brackets will be perfectly aligned with the test. I find that a bit difficult to read, hence this way of getting around it.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107969/#review24105
-----------------------------------------------------------


On Dec. 28, 2012, 2:48 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107969/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 2:48 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch implements support for math formulas in the EPUB filter. This is the first one of the EPUB3 features that we want to add to Calligra 2.7.
> 
> This version only supports math formulas saved as an embedded document, like LibreOffice and the OpenOffice variants save it. Calligra saves math formulas as inline mathML in the frame, which is not supported by this version. I thought that I could get some initial feedback while implementing support for the Calligra way too.
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/OdfParser.cpp 6069b89 
>   filters/words/epub/OdtHtmlConverter.h 68aaffa 
>   filters/words/epub/OdtHtmlConverter.cpp d4b7199 
>   filters/words/epub/exportepub2.cpp 84d8a90 
>   filters/words/epub/exporthtml.cpp bdd33e7 
> 
> Diff: http://git.reviewboard.kde.org/r/107969/diff/
> 
> 
> Testing
> -------
> 
> Created one simple odt using OOo which has a formula and some text.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121230/a3f77e25/attachment.htm>