<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107969/">http://git.reviewboard.kde.org/r/107969/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 28th, 2012, 2:45 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there is a few places where you have:
if ()
{
and one place where there is no {} after if
other than that I've not looked yet - I assume you want moji to review</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The
if ()
{
construct is only used where the test is >1 line. If I put the { at the end of the line, the first statement inside the brackets will be perfectly aligned with the test. I find that a bit difficult to read, hence this way of getting around it.
</pre>
<br />
<p>- Inge</p>
<br />
<p>On December 28th, 2012, 2:48 a.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 2:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements support for math formulas in the EPUB filter. This is the first one of the EPUB3 features that we want to add to Calligra 2.7.
This version only supports math formulas saved as an embedded document, like LibreOffice and the OpenOffice variants save it. Calligra saves math formulas as inline mathML in the frame, which is not supported by this version. I thought that I could get some initial feedback while implementing support for the Calligra way too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created one simple odt using OOo which has a formula and some text.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/epub/OdfParser.cpp <span style="color: grey">(6069b89)</span></li>
<li>filters/words/epub/OdtHtmlConverter.h <span style="color: grey">(68aaffa)</span></li>
<li>filters/words/epub/OdtHtmlConverter.cpp <span style="color: grey">(d4b7199)</span></li>
<li>filters/words/epub/exportepub2.cpp <span style="color: grey">(84d8a90)</span></li>
<li>filters/words/epub/exporthtml.cpp <span style="color: grey">(bdd33e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107969/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>