Review Request: Remove usages of QString::null or resetting QStrings by = QString()

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107807/#review24120
-----------------------------------------------------------


This review has been submitted with commit 0d32fcd9b8e77a67b94ed2a82fc164f8ab9840e1 by Jean-Nicolas Artaud on behalf of Friedrich W. H. Kossebau to branch flake-configwidgets-boemann.

- Commit Hook


On Dec. 18, 2012, 9:06 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107807/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 9:06 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> While I am pretty sure this patch does not break something, it's quite some lines, so I think you prefer to have another pair of eyes check this.
> 
> Patch removes usages of QString::null, resetting a QString by = QString() and unneeded reinitialisations in constructors.
> 
> 
> Diffs
> -----
> 
>   filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h 442ac67 
>   filters/libmsooxml/MsooXmlDrawingTableStyleReader.cpp ec1963c 
>   filters/libmsooxml/MsooXmlVmlReaderImpl.h 0c3a7b1 
>   filters/sheets/excel/sidewinder/excel.cpp 72c3fbe 
>   filters/sheets/excel/sidewinder/utils.cpp 01b92a4 
>   filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp 757d42b 
>   filters/words/docx/DocxXmlDocumentReader.cpp 634d3b9 
>   filters/words/docx/DocxXmlNumberingReader.cpp 6295a93 
>   filters/words/msword-odf/texthandler.h e80f8ad 
>   kexi/kexiutils/KexiCommandLinkButton.cpp 35d1119 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp e3a9cab 
>   krita/image/tests/kis_base_node_test.cpp 2329b8f 
>   krita/image/tests/kis_paint_device_test.cpp 071e5e3 
>   krita/plugins/formats/psd/psd_layer_section.cpp 4e13395 
>   krita/plugins/paintops/libbrush/abrbrush.cpp 0deb375 
>   krita/plugins/paintops/libbrush/kis_abr_brush.cpp 3abf1dd 
>   krita/plugins/paintops/libbrush/kis_abr_brush_collection.cpp 1539a3a 
>   krita/plugins/paintops/libbrush/kis_abr_translator.h bccc4bc 
>   krita/plugins/paintops/libbrush/kis_abr_translator.cpp 0367156 
>   krita/ui/kra/kis_kra_loader.cpp 8c8ecd9 
>   libs/flake/KoShapeFactoryBase.h 5722148 
>   libs/flake/KoShapeSavingContext.h 4801b29 
>   libs/flake/KoToolManager.cpp 4e09a8d 
>   libs/koreport/wrtembed/KoReportDesigner.cpp e6eff07 
>   libs/main/rdf/KoDocumentRdf.cpp 4c60090 
>   libs/odf/KoElementReference.cpp b51f97f 
>   libs/odf/KoOdfBibliographyConfiguration.cpp 19799cc 
>   libs/odf/KoOdfLineNumberingConfiguration.cpp 8fefb48 
>   libs/odf/KoOdfNotesConfiguration.cpp a456eb0 
>   libs/odf/KoOdfNumberDefinition.cpp d87120a 
>   libs/odf/tests/kodomtest.cpp fd7defc 
>   plugins/colorengines/lcms2/colorspaces/ycbcr_f32/YCbCrF32ColorSpace.h 01f16ba 
>   plugins/colorengines/lcms2/colorspaces/ycbcr_u16/YCbCrU16ColorSpace.h 81796e5 
>   plugins/colorengines/lcms2/colorspaces/ycbcr_u8/YCbCrU8ColorSpace.h 78d00ca 
>   stage/part/KPrViewModeSlidesSorter.cpp ca3d9b5 
>   words/part/KWPageStyle.cpp 0faab80 
>   words/part/dialogs/KWAnchoringProperties.cpp 558b48c 
> 
> Diff: http://git.reviewboard.kde.org/r/107807/diff/
> 
> 
> Testing
> -------
> 
> No changes in unit tests.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121228/15bae174/attachment.htm>