Review Request: Move kdchart from plugins/chartshape to 3rdparty/

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107747/#review23524
-----------------------------------------------------------

Ship it!


Looks fine to me, a nice cleanup.

- Boudewijn Rempt


On Dec. 15, 2012, 11:59 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107747/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 11:59 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch moves the next 3rd party library, namely kdchart, to 3rdparty/.
> 
> To test this, in addition to applying this patch you must type
> 
>   git mv plugins/chartchape/kdchart 3rdparty
> 
> And if you want, also:
> 
>   git mv plugins/chartchape/kdchartpathces 3rdparty
> 
> but that will not result in any code changes.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt a167fa3 
>   CMakeLists.txt 518954e 
>   plan/CMakeLists.txt 8a8931f 
>   plan/libs/models/CMakeLists.txt 18c7af3 
>   plan/libs/ui/CMakeLists.txt 4546a20 
>   plugins/chartshape/CMakeLists.txt 1acbd63 
>   plugins/chartshape/tests/CMakeLists.txt e67a0cb 
>   plugins/reporting/chart/CMakeLists.txt 1d80ca9 
> 
> Diff: http://git.reviewboard.kde.org/r/107747/diff/
> 
> 
> Testing
> -------
> 
> make test
> 
> and
> 
> calligrawords allcharts.odt
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121216/db98b484/attachment.htm>