<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107747/">http://git.reviewboard.kde.org/r/107747/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me, a nice cleanup.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On December 15th, 2012, 11:59 p.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2012, 11:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves the next 3rd party library, namely kdchart, to 3rdparty/.
To test this, in addition to applying this patch you must type
git mv plugins/chartchape/kdchart 3rdparty
And if you want, also:
git mv plugins/chartchape/kdchartpathces 3rdparty
but that will not result in any code changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make test
and
calligrawords allcharts.odt
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/CMakeLists.txt <span style="color: grey">(a167fa3)</span></li>
<li>CMakeLists.txt <span style="color: grey">(518954e)</span></li>
<li>plan/CMakeLists.txt <span style="color: grey">(8a8931f)</span></li>
<li>plan/libs/models/CMakeLists.txt <span style="color: grey">(18c7af3)</span></li>
<li>plan/libs/ui/CMakeLists.txt <span style="color: grey">(4546a20)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(1acbd63)</span></li>
<li>plugins/chartshape/tests/CMakeLists.txt <span style="color: grey">(e67a0cb)</span></li>
<li>plugins/reporting/chart/CMakeLists.txt <span style="color: grey">(1d80ca9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107747/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>