Review Request: [GCI] Adding d-pointers to kexi/formeditor

[Jarosław Staniek]

> On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wrote:
> > kexi/formeditor/container.cpp, line 1043
> > <http://git.reviewboard.kde.org/r/107647/diff/1/?file=97892#file97892line1043>
> >
> >     please move '{' to new row

not fixed (4 methods)


> On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wrote:
> > kexi/formeditor/container.cpp, line 1116
> > <http://git.reviewboard.kde.org/r/107647/diff/1/?file=97892#file97892line1116>
> >
> >     please move '{' to new row

fix { in two more methods below
void Container::setLayoutSpacing(int spacing)
void Container::setLayoutMargin(int margin)


> On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wrote:
> > kexi/formeditor/kexiformeventhandler.cpp, line 80
> > <http://git.reviewboard.kde.org/r/107647/diff/1/?file=97900#file97900line80>
> >
> >     Missing & in 'const QString ActionOption'

not fixed


> On Dec. 9, 2012, 11:45 p.m., Jarosław Staniek wrote:
> > kexi/formeditor/objecttree.cpp, line 284
> > <http://git.reviewboard.kde.org/r/107647/diff/1/?file=97904#file97904line284>
> >
> >     missing 'delete d'

Not resolved


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107647/#review23230
-----------------------------------------------------------


On Dec. 10, 2012, 6:48 p.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107647/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2012, 6:48 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch adding d-pointers to kexi/formeditor
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/FormWidget.h 87b3889 
>   kexi/formeditor/FormWidget.cpp bb83f98 
>   kexi/formeditor/WidgetTreeWidget.h 01d3727 
>   kexi/formeditor/WidgetTreeWidget.cpp a90aa01 
>   kexi/formeditor/connectiondialog.h 712ebe0 
>   kexi/formeditor/connectiondialog.cpp d89c46c 
>   kexi/formeditor/container.h 696361e 
>   kexi/formeditor/container.cpp 26d2f78 
>   kexi/formeditor/events.h ea498c5 
>   kexi/formeditor/events.cpp 04c5394 
>   kexi/formeditor/factories/containerfactory.cpp 95f155f 
>   kexi/formeditor/factories/stdwidgetfactory.cpp b010745 
>   kexi/formeditor/form.cpp 7f884ff 
>   kexi/formeditor/formIO.cpp ee11860 
>   kexi/formeditor/kexiformeventhandler.h 4482ba3 
>   kexi/formeditor/kexiformeventhandler.cpp 97face3 
>   kexi/formeditor/libactionwidget.h 63b120e 
>   kexi/formeditor/libactionwidget.cpp bc5d2bf 
>   kexi/formeditor/objecttree.h a37c220 
>   kexi/formeditor/objecttree.cpp 4544781 
>   kexi/formeditor/resizehandle.h c2b5116 
>   kexi/formeditor/resizehandle.cpp 4d70b0f 
>   kexi/formeditor/richtextdialog.h 5b8fc73 
>   kexi/formeditor/richtextdialog.cpp 3aa27f7 
>   kexi/formeditor/tabstopdialog.h d725344 
>   kexi/formeditor/tabstopdialog.cpp f45e56a 
>   kexi/formeditor/widgetfactory.h 0dd8c46 
>   kexi/formeditor/widgetfactory.cpp 145d513 
>   kexi/formeditor/widgetlibrary.h 81006cf 
>   kexi/formeditor/widgetlibrary.cpp 4e3a941 
>   kexi/formeditor/widgetwithsubpropertiesinterface.h 9b51b52 
>   kexi/formeditor/widgetwithsubpropertiesinterface.cpp 7d80f82 
> 
> Diff: http://git.reviewboard.kde.org/r/107647/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121210/08dfd702/attachment.htm>