Review Request: [GCI] Adding d-pointers to kexi/formeditor

Jarosław Staniek staniek at kde.org
Sun Dec 9 23:45:15 GMT 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107647/#review23230
-----------------------------------------------------------


Please carefully fix the issues, thanks.


kexi/formeditor/WidgetTreeWidget.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17794>

    Data -> data_



kexi/formeditor/WidgetTreeWidget.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17795>

    data(data) -> data(data_)



kexi/formeditor/WidgetTreeWidget.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17796>

    missing 'delete d'



kexi/formeditor/WidgetTreeWidget.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17797>

    missing 'delete d'



kexi/formeditor/WidgetTreeWidget.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17798>

    please remove this ifdef too



kexi/formeditor/connectiondialog.h
<http://git.reviewboard.kde.org/r/107647/#comment17800>

    protected -> private



kexi/formeditor/connectiondialog.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17802>

    use opposite order to avoid warning



kexi/formeditor/container.h
<http://git.reviewboard.kde.org/r/107647/#comment17804>

    move setLayout() to protected section



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17806>

    don't use m_ prefix for attributes here



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17807>

    no need to add these methods



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17808>

    make these attributed public in Private class; remove m_ prefix



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17816>

    please move '{' to new row



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17817>

    please move '{' to new row



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17819>

    please move '{' to new row



kexi/formeditor/events.h
<http://git.reviewboard.kde.org/r/107647/#comment17820>

    please move implementation of destructor to events.cpp 



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17822>

    (convention): please use sender_, not Sender, etc



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17823>

    missing 'delete d' in destructor



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17824>

    +empty row after



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17825>

    +empty row after



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17826>

    +empty row after



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17827>

    +empty row after



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17828>

    +empty row after



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17829>

    +empty row after



kexi/formeditor/events.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17830>

    +empty row after



kexi/formeditor/kexiformeventhandler.h
<http://git.reviewboard.kde.org/r/107647/#comment17801>

    protected -> private



kexi/formeditor/kexiformeventhandler.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17831>

    (convention): ActionName -> actionName_, etc.



kexi/formeditor/kexiformeventhandler.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17832>

    Missing & in 'const QString ActionOption'



kexi/formeditor/kexiformeventhandler.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17833>

    missing 'delete d'



kexi/formeditor/kexiformeventhandler.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17835>

    not needed, moved to Private constructor



kexi/formeditor/kexiformeventhandler.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17836>

    missing 'delete d'



kexi/formeditor/libactionwidget.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17837>

    missing 'delete d'



kexi/formeditor/objecttree.h
<http://git.reviewboard.kde.org/r/107647/#comment17838>

    x -> set



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17839>

    (convention): Name -> name_



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17842>

    not needed for now



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17840>

    enabled/row/col/rowspan/colspan/span uninitialized here



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17841>

    -not moved to ~Private()
    -missing 'delete d'



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17843>

    x -> set



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17844>

    move '{' to new row



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17845>

    move '{' to new row



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17846>

    move '{' to new row



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17847>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17848>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17850>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17849>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17851>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17852>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17853>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17854>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17855>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17856>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17857>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17858>

    move '{' to new row



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17859>

    move '{' to new row



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17861>

    move '{' to new row, add empty row after method



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17860>

    move '{' to new row



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17862>

    missing 'delete d'



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17863>

    use name()



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17864>

    use container()



kexi/formeditor/resizehandle.h
<http://git.reviewboard.kde.org/r/107647/#comment17865>

    move contents of Private to .cpp, only keep 'class Private' here.



kexi/formeditor/resizehandle.h
<http://git.reviewboard.kde.org/r/107647/#comment17866>

    move impl. to .cpp



kexi/formeditor/resizehandle.h
<http://git.reviewboard.kde.org/r/107647/#comment17867>

    move impl. to .cpp



kexi/formeditor/resizehandle.h
<http://git.reviewboard.kde.org/r/107647/#comment17868>

    move contents of Private to .cpp, only keep 'class Private' here.



kexi/formeditor/resizehandle.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17869>

    use new Private(set, pos)



kexi/formeditor/resizehandle.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17870>

    move dragging to the initialization list



kexi/formeditor/resizehandle.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17871>

    move widget to the initialization list



kexi/formeditor/resizehandle.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17872>

    remove this unused code


- Jarosław Staniek


On Dec. 9, 2012, 5:48 p.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107647/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2012, 5:48 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch adding d-pointers to kexi/formeditor
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/FormWidget.h 87b3889 
>   kexi/formeditor/FormWidget.cpp bb83f98 
>   kexi/formeditor/WidgetTreeWidget.h 01d3727 
>   kexi/formeditor/WidgetTreeWidget.cpp a90aa01 
>   kexi/formeditor/connectiondialog.h 712ebe0 
>   kexi/formeditor/connectiondialog.cpp d89c46c 
>   kexi/formeditor/container.h 696361e 
>   kexi/formeditor/container.cpp 26d2f78 
>   kexi/formeditor/events.h ea498c5 
>   kexi/formeditor/events.cpp 04c5394 
>   kexi/formeditor/factories/containerfactory.cpp 95f155f 
>   kexi/formeditor/factories/stdwidgetfactory.cpp b010745 
>   kexi/formeditor/form.cpp 7f884ff 
>   kexi/formeditor/formIO.cpp ee11860 
>   kexi/formeditor/kexiformeventhandler.h 4482ba3 
>   kexi/formeditor/kexiformeventhandler.cpp 97face3 
>   kexi/formeditor/libactionwidget.h 63b120e 
>   kexi/formeditor/libactionwidget.cpp bc5d2bf 
>   kexi/formeditor/objecttree.h a37c220 
>   kexi/formeditor/objecttree.cpp 4544781 
>   kexi/formeditor/resizehandle.h c2b5116 
>   kexi/formeditor/resizehandle.cpp 4d70b0f 
>   kexi/formeditor/richtextdialog.h 5b8fc73 
>   kexi/formeditor/richtextdialog.cpp 3aa27f7 
>   kexi/formeditor/tabstopdialog.h d725344 
>   kexi/formeditor/tabstopdialog.cpp f45e56a 
>   kexi/formeditor/widgetfactory.h 0dd8c46 
>   kexi/formeditor/widgetfactory.cpp 145d513 
>   kexi/formeditor/widgetlibrary.h 81006cf 
>   kexi/formeditor/widgetlibrary.cpp 4e3a941 
>   kexi/formeditor/widgetwithsubpropertiesinterface.h 9b51b52 
>   kexi/formeditor/widgetwithsubpropertiesinterface.cpp 7d80f82 
> 
> Diff: http://git.reviewboard.kde.org/r/107647/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121209/4d1d8db1/attachment.htm>

More information about the calligra-devel mailing list