Review Request: modified visualimagecompare

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107638/#review23175
-----------------------------------------------------------


There is one problem with the choosen implementation that needs to be fixed so this can work. Please see the inline comment. The resizing of the images already looks good.


tools/cstester/visualimagecompare/CompareView.cpp
<http://git.reviewboard.kde.org/r/107638/#comment17727>

    This does not work as it makes the widget as bit as the desktop allways. So the window border and menu is always outside of the screen. Also it will make the used space bigger in the case the screen is bigger.
    It is wanted that the size of the program can be adjusted by the user and the size of the images is then adjusted to fit.
    I think it should never get bigger than it is now as defined by the thumbnail size.


- Thorsten Zachmann


On Dec. 8, 2012, 7:13 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107638/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2012, 7:13 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> modified visualimagecompare as stated in - http://www.google-melange.com/gci/task/view/google/gci2012/8027210
> 
> 
> Diffs
> -----
> 
>   tools/cstester/visualimagecompare/CompareView.h 79f5e79 
>   tools/cstester/visualimagecompare/CompareView.cpp ba05bb2 
> 
> Diff: http://git.reviewboard.kde.org/r/107638/diff/
> 
> 
> Testing
> -------
> 
> yes, testing done
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121209/18eeea4e/attachment.htm>