Review Request: Fix Mobi format problems

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107526/#review22913
-----------------------------------------------------------

Ship it!


Very nice. I cannot actually test it since I don't own a Kindle but the code itsef is ok.

This is ok to merge into master and I'd very much prefer to also put it into 2.6 since otherwise mobi won't work at all, making the filter pointless.


filters/words/mobi/MobiFile.cpp
<http://git.reviewboard.kde.org/r/107526/#comment17481>

    Now we're talking!  Awesome comments!



filters/words/mobi/MobiHeaderGenerator.cpp
<http://git.reviewboard.kde.org/r/107526/#comment17482>

    The cast to qint32 here is not necessary since it's all assigned to recordOffset anyway in the end.
    
    Just a note, you don't have to change anything.


- Inge Wallin


On Dec. 2, 2012, 3:18 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107526/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2012, 3:18 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This fixes are becuse that Kindle device couldn't open our Mobi format.
> The first problem was about html text content that i used for mobi, it was not standard, sor for have a standard Mobi html i create OdtMobiHtmlConverter
> a copy of OdtHtmlConverter. I changed it t have a one, for that i neede inline attributes in elements no CSS, and i think we can merge it to OdtHtmlConverter.
> 
> Now with these fixes we support images, bookmarks (not very well), And Kindle can open our mobi correct without any problem.
> 
> 
> Diffs
> -----
> 
>   filters/words/mobi/CMakeLists.txt 88633a7 
>   filters/words/mobi/MobiFile.cpp 29c3551 
>   filters/words/mobi/MobiHeaderGenerator.h 7864620 
>   filters/words/mobi/MobiHeaderGenerator.cpp 378a01a 
>   filters/words/mobi/OdtMobiHtmlConverter.h PRE-CREATION 
>   filters/words/mobi/OdtMobiHtmlConverter.cpp PRE-CREATION 
>   filters/words/mobi/PalmDocCompression.h 2c7ed71 
>   filters/words/mobi/PalmDocCompression.cpp 4df0067 
>   filters/words/mobi/exportmobi.cpp 455b526 
> 
> Diff: http://git.reviewboard.kde.org/r/107526/diff/
> 
> 
> Testing
> -------
> 
> I have tested ebooks in Kidle Desktop Previewer for windows.
> And also tested on Kidle device too, no problem :)
> There is a mobi that i have converted in attach file, it is about mobi format but is not completed yet. :) 
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121202/da51169b/attachment.htm>