<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107526/">http://git.reviewboard.kde.org/r/107526/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very nice. I cannot actually test it since I don't own a Kindle but the code itsef is ok.
This is ok to merge into master and I'd very much prefer to also put it into 2.6 since otherwise mobi won't work at all, making the filter pointless.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107526/diff/3/?file=97053#file97053line159" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/mobi/MobiFile.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoFilter::ConversionStatus MobiFile::writeMobiFile(QString outputFile, MobiHeaderGenerator &headerGenerator)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">156</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm">/* Known Values: 1=mobigen, 2=Mobipocket Creator, 200=kindlegen (Windows),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now we're talking! Awesome comments!</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107526/diff/3/?file=97055#file97055line253" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/mobi/MobiHeaderGenerator.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MobiHeaderGenerator::generatePalmDataBase()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">235</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_dbHeader</span><span class="o">-></span><span class="n">recordOffset</span> <span class="o">+=</span> <span class="mi"><span class="hl">36</span></span><span class="p">;</span> <span class="c1">// FLIS record size.</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">218</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_dbHeader</span><span class="o">-></span><span class="n">recordOffset</span> <span class="o">+=</span> <span class="n"><span class="hl">qint32</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">36</span></span><span class="p"><span class="hl">)</span>;</span> <span class="c1">// FLIS record size.</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The cast to qint32 here is not necessary since it's all assigned to recordOffset anyway in the end.
Just a note, you don't have to change anything.</pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On December 2nd, 2012, 3:18 p.m., mojtaba shahi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By mojtaba shahi.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2012, 3:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes are becuse that Kindle device couldn't open our Mobi format.
The first problem was about html text content that i used for mobi, it was not standard, sor for have a standard Mobi html i create OdtMobiHtmlConverter
a copy of OdtHtmlConverter. I changed it t have a one, for that i neede inline attributes in elements no CSS, and i think we can merge it to OdtHtmlConverter.
Now with these fixes we support images, bookmarks (not very well), And Kindle can open our mobi correct without any problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested ebooks in Kidle Desktop Previewer for windows.
And also tested on Kidle device too, no problem :)
There is a mobi that i have converted in attach file, it is about mobi format but is not completed yet. :) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/mobi/CMakeLists.txt <span style="color: grey">(88633a7)</span></li>
<li>filters/words/mobi/MobiFile.cpp <span style="color: grey">(29c3551)</span></li>
<li>filters/words/mobi/MobiHeaderGenerator.h <span style="color: grey">(7864620)</span></li>
<li>filters/words/mobi/MobiHeaderGenerator.cpp <span style="color: grey">(378a01a)</span></li>
<li>filters/words/mobi/OdtMobiHtmlConverter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/OdtMobiHtmlConverter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/PalmDocCompression.h <span style="color: grey">(2c7ed71)</span></li>
<li>filters/words/mobi/PalmDocCompression.cpp <span style="color: grey">(4df0067)</span></li>
<li>filters/words/mobi/exportmobi.cpp <span style="color: grey">(455b526)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107526/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>