Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area
Thomas Pfeiffer
colomar at autistici.org
Fri Aug 31 19:40:10 BST 2012
> On Aug. 28, 2012, 8:27 p.m., Inge Wallin wrote:
> > words/part/dockers/KWStatisticsDocker.ui, line 25
> > <http://git.reviewboard.kde.org/r/106252/diff/1/?file=82046#file82046line25>
> >
> > I'm not sure which screenshot Thomas is talking about but I agree that this group box seems unnecessary. The layout should be enough. Also if there is any outer padding or margin, it could be set to something very small.
>
> Thomas Pfeiffer wrote:
> Oh, she forgot to attach the screenshot. It's here:
> http://imagebin.org/226166
That was the original one, it's outdated by now.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106252/#review18194
-----------------------------------------------------------
On Aug. 31, 2012, 12:19 p.m., Shreya Pandit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106252/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2012, 12:19 p.m.)
>
>
> Review request for Calligra, Thomas Pfeiffer and Inge Wallin.
>
>
> Description
> -------
>
> This allows the Statistics Docker to update its layout horizontally, when placed in bottom area.
>
>
> Diffs
> -----
>
> words/part/dockers/KWStatistics.h c480502
> words/part/dockers/KWStatistics.cpp a006d97
> words/part/dockers/KWStatisticsDocker.h fab6c7f
> words/part/dockers/KWStatisticsDocker.cpp 0bc8130
> words/part/dockers/KWStatisticsDocker.ui 63eaee5
> words/part/dockers/StatisticsPreferencesPopup.h b481806
> words/part/dockers/StatisticsPreferencesPopup.cpp c741622
>
> Diff: http://git.reviewboard.kde.org/r/106252/diff/
>
>
> Testing
> -------
>
> Checked for calligra words and calligra author
>
>
> Screenshots
> -----------
>
> The layout
> http://git.reviewboard.kde.org/r/106252/s/713/
>
>
> Thanks,
>
> Shreya Pandit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120831/743a7738/attachment.htm>
More information about the calligra-devel
mailing list