Review Request: Enable Solver plugin and its translations in Calligra Sheets

Yuri Chornoivan yurchor at ukr.net
Tue Aug 28 18:02:29 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106253/
-----------------------------------------------------------

Review request for Calligra and Marijn Kruisselbrink.


Description
-------

Current version of Calligra Sheets contains Solver plugin (kspreadsolver.so). This is not loaded due to the mistake in rc-file, it tries to load translation catalog "kspreadsolver" but Messages.sh extracts into tablessolver.pot, and Tables was renamed to Sheets.

This patch resolves some inconsistencies to make plugin loadable and translatable.


This addresses bug 126630.
    http://bugs.kde.org/show_bug.cgi?id=126630


Diffs
-----

  sheets/calligra_sheets_export.h 03168ca 
  sheets/plugins/solver/CMakeLists.txt 8ccd1f7 
  sheets/plugins/solver/Messages.sh 50839d9 
  sheets/plugins/solver/Solver.cpp f5bbd8e 
  sheets/plugins/solver/solver.rc 4d92a29 

Diff: http://git.reviewboard.kde.org/r/106253/diff/


Testing
-------

Tested with current git/master. Plugin loads and works as expected. After correction of catalog name (tablessolver.mo->sheetssolver.mo) it is completely translatable.


Thanks,

Yuri Chornoivan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120828/07754a18/attachment.htm>


More information about the calligra-devel mailing list